From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch v2] ath6kl: use a larger buffer for debug output
Date: Thu, 24 Nov 2011 14:29:45 +0200 [thread overview]
Message-ID: <4ECE38B9.4080902@qca.qualcomm.com> (raw)
In-Reply-To: <20111123063450.GA3363@mwanda>
On 11/23/2011 08:34 AM, Dan Carpenter wrote:
> The return value of snprintf() is the number of bytes which would
> have been copied if there was enough space, but we want the number of
> bytes actually copied. The scnprintf() function does this.
>
> Also in theory, a %u can take take 10 digits so we may as well make
> the buffer larger as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
> v2: I didn't know about the scnprintf() function before. Thanks
> Johannes.
Me neither, so thank you from me as well :)
Kalle
prev parent reply other threads:[~2011-11-24 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 14:09 [patch] ath6kl: use a larger buffer for debug output Dan Carpenter
2011-11-18 14:11 ` Johannes Berg
2011-11-21 16:55 ` Kalle Valo
2011-11-21 19:58 ` Dan Carpenter
2011-11-23 6:34 ` [patch v2] " Dan Carpenter
2011-11-24 12:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE38B9.4080902@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=dan.carpenter@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).