linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Arend van Spriel <arend@broadcom.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"Michael Büsch" <m@bues.ch>, "Rafał Miłecki" <zajec5@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: bcma USB Host driver
Date: Sat, 26 Nov 2011 00:56:13 +0100	[thread overview]
Message-ID: <4ED02B1D.7030409@hauke-m.de> (raw)
In-Reply-To: <4ECB8C82.5040003@broadcom.com>

Hi Arend,

On 11/22/2011 12:50 PM, Arend van Spriel wrote:
> On 11/21/2011 10:56 PM, Hauke Mehrtens wrote:
>> Hi,
>>
>> To provide ehci and ohci at the same time I came up with some solutions:
>>
>> 1. The OHCI driver also initializes the EHCI driver, when it gets load
>> and is an USB 2.0 device. This is how it is done in OpenWrt and I do not
>> like it [1].
>> 2. bcma provides two devices with different identification and there are
>> two independ drivers working with it.
> 
> When doing this the wrapper access (bcma_aread/awrite) will have effect
> on both not-so-independent drivers.
Yes that will be a workaround for this problem and will probably cause
problems when some other new features are added as we have an additional
corner case to handle.

>> 3. bcma handles the usb registration directly and all code goes to
>> drivers/bcma/
> 
> Sound like mixing device driver functionality in a bus driver. It does
> not feel right to me, but bcma is already handling chipcommon, and
> pci(e) cores.
> 
> Main question would be whether a linux device driver can provide
> multiple system functions. I tend to say it can. So I would suggest to
> have a single device driver providing OHCI and EHCI functionality.

@USB guys, how do I design a driver for a linux device providing ohci
and ehci functionality at the same time. The device has two address
spaces one for ehci and one for ohci functions.
I thought about registering one controller (ehci or ohci) with
usb_create_shared_hcd(). The code then will be in an own module and not
in echi_hcd.ko and ochi_hcd.ko like for pci, I hope this works.
Is there a better solution to do this, is there an other driver with the
same problem already solved?

>> 4. Is there some way like a platform device with a memory address which
>> I could register and which is then handled by the usb system?
>>
>> Are there any better approaches on how to do this? I do not think I am
>> the first person with such a problem.
>>
>> Hauke
>>
> 
> Gr. AvS
> 
> ps.: I polled again internally about et driver support. Keep you posted.
> 

  reply	other threads:[~2011-11-25 23:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 21:56 bcma USB Host driver Hauke Mehrtens
2011-11-22 11:50 ` Arend van Spriel
2011-11-25 23:56   ` Hauke Mehrtens [this message]
2011-11-26  1:27     ` Alan Stern
2011-11-27  0:18       ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED02B1D.7030409@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=arend@broadcom.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).