From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:52718 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755383Ab1K2Rw6 (ORCPT ); Tue, 29 Nov 2011 12:52:58 -0500 Message-ID: <4ED51BF5.9010508@candelatech.com> (sfid-20111129_185304_555451_9908AFF9) Date: Tue, 29 Nov 2011 09:52:53 -0800 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org Subject: Re: [PATCH v3] iw: Support ht-capability overrides mask. References: <1322505622-13446-1-git-send-email-greearb@candelatech.com> (sfid-20111128_194043_702798_6A11361F) <1322556714.4110.13.camel@jlt3.sipsolutions.net> In-Reply-To: <1322556714.4110.13.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/29/2011 12:51 AM, Johannes Berg wrote: > On Mon, 2011-11-28 at 10:40 -0800, greearb@candelatech.com wrote: >> From: Ben Greear >> >> Let user know which capabilities are supported. > > I applied this with a bunch of modifications, but I think you should > follow up and make it more complete. You're covering exactly and only > the case that you're working on right now, I don't think that's good > practice. It looks to me like your change isn't going to compile on older systems (Fedora Core 8, for instance), because htole16 isn't defined there (no endian.h file). That is why I hand-coded an equivalent method... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com