Moving scan logic into work-queue?

Moving scan logic into work-queue?

[Ben Greear]

We've talked before about moving the scan logic into the work-queue.

Since my previous attempts at optimizing this code for scanning & off-channel
work didn't stick, I thought I might attempt to convert the scan logic
to the work-queue, with hopes of then being able to make another attempt
at optimizing things for multiple interfaces & potentially off-channel work
items.

Before I start though, I'm hoping for some guidance on how you'd
want this implemented.  Or, if you think there are other changes
that should go in first, I'll wait...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: Moving scan logic into work-queue?

[Johannes Berg]

On Tue, 2011-11-29 at 10:13 -0800, Ben Greear wrote:
> We've talked before about moving the scan logic into the work-queue.

I think you mean ieee80211_work, not work-queue.

> Since my previous attempts at optimizing this code for scanning & off-channel
> work didn't stick, I thought I might attempt to convert the scan logic
> to the work-queue, with hopes of then being able to make another attempt
> at optimizing things for multiple interfaces & potentially off-channel work
> items.
> 
> Before I start though, I'm hoping for some guidance on how you'd
> want this implemented.  Or, if you think there are other changes
> that should go in first, I'll wait...

In any case, yes, please don't work on this now. I need to rework auth &
assoc handling completely, and get rid of the work items for that etc.
That will probably mean a large rewrite of the work item logic, possibly
even removing most of that code.

johannes

Re: Moving scan logic into work-queue?

[Ben Greear]

On 11/29/2011 10:15 AM, Johannes Berg wrote:
> On Tue, 2011-11-29 at 10:13 -0800, Ben Greear wrote:
>> We've talked before about moving the scan logic into the work-queue.
>
> I think you mean ieee80211_work, not work-queue.
>
>> Since my previous attempts at optimizing this code for scanning&  off-channel
>> work didn't stick, I thought I might attempt to convert the scan logic
>> to the work-queue, with hopes of then being able to make another attempt
>> at optimizing things for multiple interfaces&  potentially off-channel work
>> items.
>>
>> Before I start though, I'm hoping for some guidance on how you'd
>> want this implemented.  Or, if you think there are other changes
>> that should go in first, I'll wait...
>
> In any case, yes, please don't work on this now. I need to rework auth&
> assoc handling completely, and get rid of the work items for that etc.
> That will probably mean a large rewrite of the work item logic, possibly
> even removing most of that code.

Ok, I'll wait to see how that turns out.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com