* [patch] brcm80211: fmac: small memory leak on error
@ 2011-11-30 8:49 Dan Carpenter
2011-11-30 18:42 ` Franky Lin
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-30 8:49 UTC (permalink / raw)
To: John W. Linville
Cc: Franky Lin, Arend van Spriel, Pieter-Paul Giesberts,
Alwin Beukers, linux-wireless, kernel-janitors
We should free "bus_if" here, it's a small leak but it makes the static
checkers happy.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
index 77f84f8..b416e27 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
@@ -477,8 +477,10 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
if (!bus_if)
return -ENOMEM;
sdiodev = kzalloc(sizeof(struct brcmf_sdio_dev), GFP_KERNEL);
- if (!sdiodev)
+ if (!sdiodev) {
+ kfree(bus_if);
return -ENOMEM;
+ }
sdiodev->dev = &func->card->dev;
sdiodev->func[0] = func->card->sdio_func[0];
sdiodev->func[1] = func;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] brcm80211: fmac: small memory leak on error
2011-11-30 8:49 [patch] brcm80211: fmac: small memory leak on error Dan Carpenter
@ 2011-11-30 18:42 ` Franky Lin
0 siblings, 0 replies; 2+ messages in thread
From: Franky Lin @ 2011-11-30 18:42 UTC (permalink / raw)
To: Dan Carpenter, John W. Linville
Cc: Arend Van Spriel, Pieter-Paul Giesberts, Alwin Beukers,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
On 11/30/2011 12:49 AM, Dan Carpenter wrote:
> We should free "bus_if" here, it's a small leak but it makes the static
> checkers happy.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Thanks, Dan.
Acked-by: Franky Lin <frankyl@broadcom.com>
Franky
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-30 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 8:49 [patch] brcm80211: fmac: small memory leak on error Dan Carpenter
2011-11-30 18:42 ` Franky Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).