From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: Inform bss information to cfg80211 before connect event
Date: Fri, 2 Dec 2011 13:52:55 +0200 [thread overview]
Message-ID: <4ED8BC17.9080906@qca.qualcomm.com> (raw)
In-Reply-To: <20111202114843.GC4358@jouni.qca.qualcomm.com>
On 12/02/2011 01:48 PM, Jouni Malinen wrote:
> On Fri, Dec 02, 2011 at 03:06:59PM +0530, Vasanthakumar Thiagarajan wrote:
>> This is already done but only when bss entry is not availabe
>> or aged out. Not updating the bss information when that bss
>> is available creates a case where there is a bss entry when
>> checked in ath6kl_cfg80211_connect_event() but it got aged out
>> by the time cfg80211 checks for the bss entry in __cfg80211_roamed().
>> This results in the following warning and the failure to notify
>> roaming event to application. To fix this, update the bss information
>> for which a romaing event is received. Also renamed ath6kl_add_bss_if_needed()
>> to ath6kl_inform_bss().
>
> I don't think this is a good fix for the problem and would prefer this
> not getting applied before the real issue is fully understood.
I have already dropped this per Vasanth's request and will wait for v2.
Kalle
next prev parent reply other threads:[~2011-12-02 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 9:36 [PATCH] ath6kl: Inform bss information to cfg80211 before connect event Vasanthakumar Thiagarajan
2011-12-02 10:47 ` Vasanthakumar Thiagarajan
2011-12-02 11:48 ` Jouni Malinen
2011-12-02 11:52 ` Kalle Valo [this message]
2011-12-05 9:36 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8BC17.9080906@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).