linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: bcma usage in isr context
Date: Wed, 7 Dec 2011 15:01:42 +0100	[thread overview]
Message-ID: <4EDF71C6.9050800@broadcom.com> (raw)
In-Reply-To: <CACna6rwVRrm8YgvoYAmswru8nHXgytuiDRO2F2TQVZyxnfaV9w@mail.gmail.com>

On 12/07/2011 01:52 PM, Rafał Miłecki wrote:
> W dniu 5 grudnia 2011 16:27 użytkownik Arend van Spriel
> <arend@broadcom.com> napisał:
>>> You're right, we don't handle this properly. I'll try to send patch
>>> today to make use of fixed windows. I've it here for some time
>>> already, just didn't clean it enough.
>>>
>>
>> Ok. For now I have a patch in the bcma read/write host_pci functions
>> that solves it, but fixed bar windows are preferable.
> 
> Have you tested my patch? Does it solver your issue? I can't wait to
> see bcma patches for brcmsmac :)
> 

Not yet. I had a patch in which each read/write used a
spin_lock_irqsave/spin_unlock_irqrestore. Did not cause to much latency.
I intend to rebase my changes using your patch later today.

Your patch only works if all cores fit in the window. This is the case
for the current pci-based broadcom chipsets so the patch is fine. I will
let you know the results. I also intend to do some suspend/resume
testing. I believe there was some issue mentioned on wireless mailing
list with bcma/b43.

Gr. AvS


  reply	other threads:[~2011-12-07 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 13:09 bcma usage in isr context Arend van Spriel
2011-12-05 11:30 ` Rafał Miłecki
2011-12-05 15:27   ` Arend van Spriel
2011-12-07 12:52     ` Rafał Miłecki
2011-12-07 14:01       ` Arend van Spriel [this message]
2011-12-07 15:06         ` Rafał Miłecki
2011-12-09 17:37           ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDF71C6.9050800@broadcom.com \
    --to=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).