From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Vivek Natarajan <nataraja@qualcomm.com>
Subject: Re: [RFC 2/2] mac80211: Fix power save in change save
Date: Tue, 13 Dec 2011 14:35:06 +0530 [thread overview]
Message-ID: <4EE71542.8040602@qca.qualcomm.com> (raw)
In-Reply-To: <1323766643.3355.2.camel@jlt3.sipsolutions.net>
Hi Johannes,
On Tuesday 13 December 2011 02:27 PM, Johannes Berg wrote:
> On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> we found that power save is not getting enabled when we do
>> change interface in this order STA->IBSS->STA. this is
>> because ieee80211_setup_sdata clears type-dependen union
>>
>> Reported-by: Leela Kella<leela@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> net/mac80211/mlme.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> index 67a6be1..d87fde3 100644
>> --- a/net/mac80211/mlme.c
>> +++ b/net/mac80211/mlme.c
>> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
>> (unsigned long) sdata);
>>
>> ifmgd->flags = 0;
>> + ifmgd->powersave = sdata->wdev.ps;
>
> Makes sense.
thanks for the review, I will fix the subject name also.
>
> johannes
>
--
thanks,
shafi
prev parent reply other threads:[~2011-12-13 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 8:55 [RFC 1/2] mac80211: remove an unnecessary paraenthesis Mohammed Shafi Shajakhan
2011-12-13 8:55 ` [RFC 2/2] mac80211: Fix power save in change save Mohammed Shafi Shajakhan
2011-12-13 8:57 ` Johannes Berg
2011-12-13 9:05 ` Mohammed Shafi Shajakhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE71542.8040602@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nataraja@qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).