* [RFC 1/2] mac80211: remove an unnecessary paraenthesis
@ 2011-12-13 8:55 Mohammed Shafi Shajakhan
2011-12-13 8:55 ` [RFC 2/2] mac80211: Fix power save in change save Mohammed Shafi Shajakhan
0 siblings, 1 reply; 4+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-12-13 8:55 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Vasanthakumar Thiagarajan, Kalle Valo,
Vivek Natarajan, Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
net/mac80211/mlme.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 09019d1..67a6be1 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -819,7 +819,7 @@ void ieee80211_dynamic_ps_enable_work(struct work_struct *work)
}
if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
- (!(ifmgd->flags & IEEE80211_STA_NULLFUNC_ACKED))) {
+ !(ifmgd->flags & IEEE80211_STA_NULLFUNC_ACKED)) {
netif_tx_stop_all_queues(sdata->dev);
if (drv_tx_frames_pending(local))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RFC 2/2] mac80211: Fix power save in change save
2011-12-13 8:55 [RFC 1/2] mac80211: remove an unnecessary paraenthesis Mohammed Shafi Shajakhan
@ 2011-12-13 8:55 ` Mohammed Shafi Shajakhan
2011-12-13 8:57 ` Johannes Berg
0 siblings, 1 reply; 4+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-12-13 8:55 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Vasanthakumar Thiagarajan, Kalle Valo,
Vivek Natarajan, Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
we found that power save is not getting enabled when we do
change interface in this order STA->IBSS->STA. this is
because ieee80211_setup_sdata clears type-dependen union
Reported-by: Leela Kella <leela@qca.qualcomm.com>
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
net/mac80211/mlme.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 67a6be1..d87fde3 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
(unsigned long) sdata);
ifmgd->flags = 0;
+ ifmgd->powersave = sdata->wdev.ps;
mutex_init(&ifmgd->mtx);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC 2/2] mac80211: Fix power save in change save
2011-12-13 8:55 ` [RFC 2/2] mac80211: Fix power save in change save Mohammed Shafi Shajakhan
@ 2011-12-13 8:57 ` Johannes Berg
2011-12-13 9:05 ` Mohammed Shafi Shajakhan
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2011-12-13 8:57 UTC (permalink / raw)
To: Mohammed Shafi Shajakhan
Cc: linux-wireless, Vasanthakumar Thiagarajan, Kalle Valo,
Vivek Natarajan
On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>
> we found that power save is not getting enabled when we do
> change interface in this order STA->IBSS->STA. this is
> because ieee80211_setup_sdata clears type-dependen union
>
> Reported-by: Leela Kella <leela@qca.qualcomm.com>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> ---
> net/mac80211/mlme.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 67a6be1..d87fde3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
> (unsigned long) sdata);
>
> ifmgd->flags = 0;
> + ifmgd->powersave = sdata->wdev.ps;
Makes sense.
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC 2/2] mac80211: Fix power save in change save
2011-12-13 8:57 ` Johannes Berg
@ 2011-12-13 9:05 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 4+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-12-13 9:05 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Vasanthakumar Thiagarajan, Kalle Valo,
Vivek Natarajan
Hi Johannes,
On Tuesday 13 December 2011 02:27 PM, Johannes Berg wrote:
> On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> we found that power save is not getting enabled when we do
>> change interface in this order STA->IBSS->STA. this is
>> because ieee80211_setup_sdata clears type-dependen union
>>
>> Reported-by: Leela Kella<leela@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> net/mac80211/mlme.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> index 67a6be1..d87fde3 100644
>> --- a/net/mac80211/mlme.c
>> +++ b/net/mac80211/mlme.c
>> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
>> (unsigned long) sdata);
>>
>> ifmgd->flags = 0;
>> + ifmgd->powersave = sdata->wdev.ps;
>
> Makes sense.
thanks for the review, I will fix the subject name also.
>
> johannes
>
--
thanks,
shafi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-13 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-13 8:55 [RFC 1/2] mac80211: remove an unnecessary paraenthesis Mohammed Shafi Shajakhan
2011-12-13 8:55 ` [RFC 2/2] mac80211: Fix power save in change save Mohammed Shafi Shajakhan
2011-12-13 8:57 ` Johannes Berg
2011-12-13 9:05 ` Mohammed Shafi Shajakhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).