From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: b43-dev <b43-dev@lists.infradead.org>, linux-wireless@vger.kernel.org
Subject: Re: [RFC] b43: Rearranging functions in phy_n.c
Date: Fri, 16 Dec 2011 13:04:39 -0600 [thread overview]
Message-ID: <4EEB9647.9080208@lwfinger.net> (raw)
In-Reply-To: <CACna6rxEyGbxq813UW8RvzaysCd0jCawYZ0G6eN7XiAQOykTig@mail.gmail.com>
On 12/16/2011 12:55 PM, Rafał Miłecki wrote:
> Hey,
>
> The order of functions in phy_n.c is really messy. I wanted to collect
> related functions, fix order (dependency) and name goups via comments.
>
> Is there anything I should know? Patches are going to be huge, tons of
> lines moved around the phy_n.c :(
>
> Are there any objections against that? Any suggestions if I should
> post one huge patch or few smaller ones?
Several smaller ones always help the reviewer. I would vote for that option.
Larry
prev parent reply other threads:[~2011-12-16 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 18:55 [RFC] b43: Rearranging functions in phy_n.c Rafał Miłecki
2011-12-16 19:04 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB9647.9080208@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).