* [RFC] b43: Rearranging functions in phy_n.c
@ 2011-12-16 18:55 Rafał Miłecki
2011-12-16 19:04 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2011-12-16 18:55 UTC (permalink / raw)
To: b43-dev; +Cc: linux-wireless
Hey,
The order of functions in phy_n.c is really messy. I wanted to collect
related functions, fix order (dependency) and name goups via comments.
Is there anything I should know? Patches are going to be huge, tons of
lines moved around the phy_n.c :(
Are there any objections against that? Any suggestions if I should
post one huge patch or few smaller ones?
--
Rafał
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] b43: Rearranging functions in phy_n.c
2011-12-16 18:55 [RFC] b43: Rearranging functions in phy_n.c Rafał Miłecki
@ 2011-12-16 19:04 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2011-12-16 19:04 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: b43-dev, linux-wireless
On 12/16/2011 12:55 PM, Rafał Miłecki wrote:
> Hey,
>
> The order of functions in phy_n.c is really messy. I wanted to collect
> related functions, fix order (dependency) and name goups via comments.
>
> Is there anything I should know? Patches are going to be huge, tons of
> lines moved around the phy_n.c :(
>
> Are there any objections against that? Any suggestions if I should
> post one huge patch or few smaller ones?
Several smaller ones always help the reviewer. I would vote for that option.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-16 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 18:55 [RFC] b43: Rearranging functions in phy_n.c Rafał Miłecki
2011-12-16 19:04 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).