From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho
Date: Tue, 20 Dec 2011 13:01:36 -0600 [thread overview]
Message-ID: <4EF0DB90.50100@lwfinger.net> (raw)
In-Reply-To: <1324406771-7100-1-git-send-email-rodrigue@qca.qualcomm.com>
On 12/20/2011 12:46 PM, Luis R. Rodriguez wrote:
> From: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>
> Here's a slew of sparse warning fixes for all Atheros wireless drivers.
> These have been itching me for a while now. I ask all patch submitters
> and driver maintainers to please run their patches with these two tests:
>
> make C=1 M=drivers/net/wireless/ath/
>
> And then if all is happy try:
>
> make C=2 CF="-D__CHECK_ENDIAN__" M=drivers/net/wireless/ath/
Why not follow a suggestion that Johannes made to me? Add the line
ccflags-y += -D__CHECK_ENDIAN__
To the bottom of the make file(s). That way they only need one run. Then enforce
the rule by not ACKing any patches with too many of the endian warnings, and do
not allow any of the others.
Larry
next prev parent reply other threads:[~2011-12-20 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 18:46 [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 1/6] ath6kl: fix sparse warning on init.c Luis R. Rodriguez
2011-12-20 18:49 ` Luis R. Rodriguez
2011-12-20 19:40 ` Kalle Valo
2011-12-20 19:46 ` Luis R. Rodriguez
2011-12-20 20:02 ` Kalle Valo
2011-12-21 1:41 ` Joe Perches
2011-12-21 1:42 ` Joe Perches
2011-12-23 8:27 ` Kalle Valo
2011-12-20 18:46 ` [PATCH 2/6] ath9k: make ath_mci_duty_cycle static Luis R. Rodriguez
2011-12-21 4:41 ` Joe Perches
2011-12-21 17:26 ` Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 3/6] ath9k_hw: fix sparse warnings on ar9003_rtt.c Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 4/6] ath9k: fix tx queue sparse complaint Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 5/6] ath5k: avoid sparse warnings on tracing Luis R. Rodriguez
2011-12-21 15:15 ` Johannes Berg
2011-12-21 16:04 ` Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 6/6] ath9k_hw: fix sparse complaint on ar9003_switch_com_spdt_get() Luis R. Rodriguez
2011-12-20 19:01 ` Larry Finger [this message]
2011-12-20 19:12 ` [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0DB90.50100@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).