From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/6] ath6kl: fix sparse warning on init.c
Date: Tue, 20 Dec 2011 22:02:25 +0200 [thread overview]
Message-ID: <4EF0E9D1.4000207@qca.qualcomm.com> (raw)
In-Reply-To: <20111220194618.GD15071@tux>
On 12/20/2011 09:46 PM, Luis R. Rodriguez wrote:
> On Tue, Dec 20, 2011 at 09:40:19PM +0200, Kalle Valo wrote:
>> I always check for both compiler and sparse warnings and I have never
>> seen this. What version of compiler do you have?
>>
>> I have:
>>
>> gcc-4.5.real (Ubuntu/Linaro 4.5.2-8ubuntu4) 4.5.2
>
> Same.
>
> mcgrof@tux ~ $ gcc --version
> gcc-4.5.real (Ubuntu/Linaro 4.5.2-8ubuntu4) 4.5.2
This is odd as I don't see it, even with latest wireless-testing:
$ make M=drivers/net/wireless/ath/ath6kl
LD drivers/net/wireless/ath/ath6kl/built-in.o
CC [M] drivers/net/wireless/ath/ath6kl/debug.o
CC [M] drivers/net/wireless/ath/ath6kl/hif.o
CC [M] drivers/net/wireless/ath/ath6kl/htc.o
CC [M] drivers/net/wireless/ath/ath6kl/bmi.o
CC [M] drivers/net/wireless/ath/ath6kl/cfg80211.o
CC [M] drivers/net/wireless/ath/ath6kl/init.o
CC [M] drivers/net/wireless/ath/ath6kl/main.o
CC [M] drivers/net/wireless/ath/ath6kl/txrx.o
CC [M] drivers/net/wireless/ath/ath6kl/wmi.o
CC [M] drivers/net/wireless/ath/ath6kl/sdio.o
CC [M] drivers/net/wireless/ath/ath6kl/testmode.o
CC [M] drivers/net/wireless/ath/ath6kl/usb.o
LD [M] drivers/net/wireless/ath/ath6kl/ath6kl_sdio.o
LD [M] drivers/net/wireless/ath/ath6kl/ath6kl_usb.o
Building modules, stage 2.
MODPOST 2 modules
CC drivers/net/wireless/ath/ath6kl/ath6kl_sdio.mod.o
LD [M] drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko
CC drivers/net/wireless/ath/ath6kl/ath6kl_usb.mod.o
LD [M] drivers/net/wireless/ath/ath6kl/ath6kl_usb.ko
I really would like to understand what's happening here...
But anyway, I think your test is not needed (unless I'm blind again).
Maybe uninitialized_var() is a better choise?
Kalle
next prev parent reply other threads:[~2011-12-20 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 18:46 [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 1/6] ath6kl: fix sparse warning on init.c Luis R. Rodriguez
2011-12-20 18:49 ` Luis R. Rodriguez
2011-12-20 19:40 ` Kalle Valo
2011-12-20 19:46 ` Luis R. Rodriguez
2011-12-20 20:02 ` Kalle Valo [this message]
2011-12-21 1:41 ` Joe Perches
2011-12-21 1:42 ` Joe Perches
2011-12-23 8:27 ` Kalle Valo
2011-12-20 18:46 ` [PATCH 2/6] ath9k: make ath_mci_duty_cycle static Luis R. Rodriguez
2011-12-21 4:41 ` Joe Perches
2011-12-21 17:26 ` Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 3/6] ath9k_hw: fix sparse warnings on ar9003_rtt.c Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 4/6] ath9k: fix tx queue sparse complaint Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 5/6] ath5k: avoid sparse warnings on tracing Luis R. Rodriguez
2011-12-21 15:15 ` Johannes Berg
2011-12-21 16:04 ` Luis R. Rodriguez
2011-12-20 18:46 ` [PATCH 6/6] ath9k_hw: fix sparse complaint on ar9003_switch_com_spdt_get() Luis R. Rodriguez
2011-12-20 19:01 ` [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho Larry Finger
2011-12-20 19:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0E9D1.4000207@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).