linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: fix scan state machine
Date: Wed, 21 Dec 2011 20:24:11 +0530	[thread overview]
Message-ID: <4EF1F313.1090304@qca.qualcomm.com> (raw)
In-Reply-To: <1324479072-8242-1-git-send-email-mohammed@qca.qualcomm.com>

On Wednesday 21 December 2011 08:21 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> when we run high bandwidth UDP traffic and we trigger a scan, the scan
> state machine seems to be looping in SUSPEND->RESUME->DECISION->SUSPEND
> and SET_CHANNEL seems to be never called as 'tx_empty' is never true
> while running UDP traffic. fix this by settting SET_CHANNEL state when
> we get into RESUME state.

Hi johannes,

i am not completely familiar with the scan state machine. used some 
previous before some of your latest changes in scan state machine and
found this might help. please let me know if this does not helps 
something. thank you!

>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
>   net/mac80211/scan.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c
> index 2c5041c..2908e56 100644
> --- a/net/mac80211/scan.c
> +++ b/net/mac80211/scan.c
> @@ -625,7 +625,7 @@ static void ieee80211_scan_state_resume(struct ieee80211_local *local,
>   	local->leave_oper_channel_time = jiffies;
>
>   	/* advance to the next channel to be scanned */
> -	local->next_scan_state = SCAN_DECISION;
> +	local->next_scan_state = SCAN_SET_CHANNEL;
>   }
>
>   void ieee80211_scan_work(struct work_struct *work)


-- 
thanks,
shafi

  reply	other threads:[~2011-12-21 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 14:51 [RFC] mac80211: fix scan state machine Mohammed Shafi Shajakhan
2011-12-21 14:54 ` Mohammed Shafi Shajakhan [this message]
2011-12-21 15:31 ` Helmut Schaa
2011-12-21 15:37   ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF1F313.1090304@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).