Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger <Larry.Finger@lwfinger.net>]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On 12/22/2011 04:09 AM, Darshan Kumar NANDANWAR wrote:
> OOPs is in  following instruction :
> pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
> 656:       15 0a           mov.w   r1,@(r0,r10)
> I have attached the objdump aswell ..
>
>>> The fix came with commit b6b67df3f24c45af0012ee, which is dated Jul 29.
> What is this all about? Could you point to  this commit?

Kernel source is now maintained using git, which keeps track of changes using 
the sha1sum of the changes. The ID above is the leading digits of that sum.

The patch in question is attached. It handles the cases where the self member of 
the pci_bus struct is not present. It appears not to have been applied to your 
source. Does this patch fix your problem?

Larry



[-- Attachment #2: patch_b6b67df --]
[-- Type: text/plain, Size: 2211 bytes --]

commit b6b67df3f24c45af0012ee3c8af2f62ca083ae18
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date:   Fri Jul 29 10:53:12 2011 -0500

    rtlwifi: Fix kernel oops on ARM SOC
    
    This driver uses information from the self member of the pci_bus struct to
    get information regarding the bridge to which the PCIe device is attached.
    Unfortunately, this member is not established on all architectures, which
    leads to a kernel oops.
    
    Skipping the entire block that uses the self member to determine the bridge
    vendor will only affect RTL8192DE devices as that driver sets the ASPM support
    flag differently when the bridge vendor is Intel. If the self member is
    available, there is no functional change.
    
    This patch fixes Bugzilla No. 40212.
    
    Reported-by: Hubert Liao <liao.hubertt@gmail.com>
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Cc: Stable <stable@kernel.org> [back to 2.6.38]
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5efd578..56f1235 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -1696,15 +1696,17 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
 	pcipriv->ndis_adapter.devnumber = PCI_SLOT(pdev->devfn);
 	pcipriv->ndis_adapter.funcnumber = PCI_FUNC(pdev->devfn);
 
-	/*find bridge info */
-	pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
-	for (tmp = 0; tmp < PCI_BRIDGE_VENDOR_MAX; tmp++) {
-		if (bridge_pdev->vendor == pcibridge_vendors[tmp]) {
-			pcipriv->ndis_adapter.pcibridge_vendor = tmp;
-			RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
-				 ("Pci Bridge Vendor is found index: %d\n",
-				  tmp));
-			break;
+	if (bridge_pdev) {
+		/*find bridge info if available */
+		pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
+		for (tmp = 0; tmp < PCI_BRIDGE_VENDOR_MAX; tmp++) {
+			if (bridge_pdev->vendor == pcibridge_vendors[tmp]) {
+				pcipriv->ndis_adapter.pcibridge_vendor = tmp;
+				RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
+					 ("Pci Bridge Vendor is found index:"
+					 " %d\n", tmp));
+				break;
+			}
 		}
 	}