From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>, <pstew@chromium.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: use rcu_read_lock before sta_info_get
Date: Mon, 26 Dec 2011 10:45:07 +0530 [thread overview]
Message-ID: <4EF802DB.10100@qca.qualcomm.com> (raw)
In-Reply-To: <201112251758.41131.chunkeey@googlemail.com>
Hi Christian,
thanks for your review!
On Sunday 25 December 2011 10:28 PM, Christian Lamparter wrote:
> On Sunday 25 December 2011 16:09:12 Mohammed Shafi Shajakhan wrote:
>> @@ -1385,7 +1385,9 @@ void ieee80211_beacon_connection_loss_work(struct work_struct *work)
>> struct sta_info *sta;
>>
>> if (ifmgd->associated) {
>> + rcu_read_lock();
>> sta = sta_info_get(sdata, ifmgd->bssid);
>> + rcu_read_unlock();
>> if (sta)
>> sta->beacon_loss_count++;
>> }
>
> uh, I think it should be:
>
>> + rcu_read_lock();
>> sta = sta_info_get(sdata, ifmgd->bssid);
>> if (sta)
>> sta->beacon_loss_count++;
>> + rcu_read_unlock();
>
> Since we update a member of the rcu-protected "sta"
> reference.
ok i will add this changes also in a proper patch, thank you.
>
> Regards,
> Chr
--
thanks,
shafi
next prev parent reply other threads:[~2011-12-26 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 15:09 [RFC] mac80211: use rcu_read_lock before sta_info_get Mohammed Shafi Shajakhan
2011-12-25 16:58 ` Christian Lamparter
2011-12-26 5:15 ` Mohammed Shafi Shajakhan [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-25 15:06 Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF802DB.10100@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=chunkeey@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pstew@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).