From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: "John W Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
"Helmut Schaa" <helmut.schaa@googlemail.com>,
"Jakub Kiciński" <kubakici@wp.pl>
Subject: Re: [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding
Date: Wed, 28 Dec 2011 21:43:23 +0100 [thread overview]
Message-ID: <4EFB7F6B.8050104@gmail.com> (raw)
In-Reply-To: <CAOZOX0XauBTyaBR9j75de=BeTZ1v_rRfgdJc7BPYDsA9HYi-2w@mail.gmail.com>
On 12/28/11 21:12, Ivo Van Doorn wrote:
> On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
> <gwingerde@gmail.com> wrote:
>> From: Jakub Kiciński <kubakici@wp.pl>
>>
>> Older USB drivers does not append end padding to skb but instead report
>> it in size of data to be transmitted to HW. rt2800usb should follow that
>> behaviour. Custom write_tx_data callback which was adding pad to skb
>> is not be needed any more.
>>
>> Thanks to this patch frames handed back from rt2800usb to mac80211 will
>> no longer contain end padding.
>
> What happened to the reports that after this (and the next) patch, the
> non-2800 USB
> drivers are failing?
I have seen only 1 failure report (from Andreas Hartmann), which seemed
to have been caused by not applying both patches. ISTR that Andreas did
not see any regression when both patches were applied.
I have not seen any other reports of failures.
Also, my own testing did not reveal any issues, therefore I included
them in this batch.
<snip>
---
Gertjan.
next prev parent reply other threads:[~2011-12-28 20:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 0:53 [PATCH 0/7] Assorted fixes and clean-ups Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 1/7] rt2x00: Identify rt2800usb chipsets Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 2/7] rt2x00: Whitespace cleanup Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 3/7] rt2x00: Convert big if-statements to switch-statements Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 5/7] rt2x00usb: Zero USB padding before sending URB Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 6/7] rt2x00: RT3593 is also applicable to USB Gertjan van Wingerde
2011-12-28 0:53 ` [PATCH 7/7] rt2x00: Change RF3853 to RF3053 Gertjan van Wingerde
2011-12-28 20:12 ` Ivo Van Doorn
2011-12-28 20:12 ` [PATCH 6/7] rt2x00: RT3593 is also applicable to USB Ivo Van Doorn
2011-12-28 22:40 ` [PATCH 5/7] rt2x00usb: Zero USB padding before sending URB Ivo Van Doorn
2011-12-28 20:12 ` [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding Ivo Van Doorn
2011-12-28 20:43 ` Gertjan van Wingerde [this message]
2011-12-28 22:01 ` Andreas Hartmann
2011-12-28 22:40 ` Ivo Van Doorn
2011-12-28 22:40 ` Ivo Van Doorn
2011-12-28 20:11 ` [PATCH 3/7] rt2x00: Convert big if-statements to switch-statements Ivo Van Doorn
2011-12-28 20:10 ` [PATCH 2/7] rt2x00: Whitespace cleanup Ivo Van Doorn
2011-12-28 20:10 ` [PATCH 1/7] rt2x00: Identify rt2800usb chipsets Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFB7F6B.8050104@gmail.com \
--to=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).