From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <linville@tuxdriver.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
David Miller <davem@davemloft.net>, <linux-next@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: force building as a module
Date: Wed, 4 Jan 2012 11:48:40 +0200 [thread overview]
Message-ID: <4F042078.5040902@qca.qualcomm.com> (raw)
In-Reply-To: <20120104094134.28754.39652.stgit@x201>
On 01/04/2012 11:41 AM, Kalle Valo wrote:
> Stephen reported that ath6kl fails if both sdio and usb are built
> into the kernel:
>
> ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME'
> ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function)
> ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant
>
> As a temporary fix make ath6kl build only as a module. This will be reverted
> once a separate ath6kl core module is implemented which will fix this
> properly.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Sorry, forgot to CC people. The original patch is here:
http://marc.info/?l=linux-wireless&m=132567025132302&w=2
John, can you please take this directly so that the build problem gets
fixed quickly? I will also apply it to ath6kl.git but that should not
create any merge problems.
Kalle
next prev parent reply other threads:[~2012-01-04 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 9:41 [PATCH] ath6kl: force building as a module Kalle Valo
2012-01-04 9:48 ` Kalle Valo [this message]
2012-01-04 18:28 ` David Miller
2012-01-04 18:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F042078.5040902@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).