From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: <linville@tuxdriver.com>, <sfr@canb.auug.org.au>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-next@vger.kernel.org>,
<ath6kl-devel@qualcomm.com>, <davem@davemloft.net>
Subject: Re: [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
Date: Thu, 5 Jan 2012 10:22:32 +0200 [thread overview]
Message-ID: <4F055DC8.9050902@qca.qualcomm.com> (raw)
In-Reply-To: <1325720472.4116.7.camel@joe2Laptop>
On 01/05/2012 01:41 AM, Joe Perches wrote:
> On Thu, 2012-01-05 at 01:09 +0200, Kalle Valo wrote:
>> That way it's possible to not export debug_mask outside the upcoming
>> ath6kl_core.ko and that makes it easier to ath6kl_core.ko in the
>> following patch.
> []
>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> []
>> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> []
>> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
>> +{
>> + va_list args;
>> +
>> + if (!(debug_mask & mask))
>> + return;
>> +
>> + va_start(args, fmt);
>> + ath6kl_printk(KERN_DEBUG, fmt, &args);
>
> Passing a va_list as an argument?
> I believe this doesn't work.
Doh, I was supposed to test this but then I forgot in the hurry. Thanks
for pointing this out. I will send v2 which will fix this.
Kalle
next prev parent reply other threads:[~2012-01-05 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 23:07 [PATCH 0/6] ath6kl: create ath6kl_core.ko Kalle Valo
2012-01-04 23:07 ` [PATCH 1/6] ath6kl: rename vif init and cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 2/6] ath6kl: unify cfg80211 init/cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 3/6] ath6kl: create core.c Kalle Valo
2012-01-04 23:09 ` [PATCH 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK() Kalle Valo
2012-01-04 23:58 ` Joe Perches
2012-01-05 8:57 ` Kalle Valo
2012-01-04 23:09 ` [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions Kalle Valo
2012-01-04 23:41 ` Joe Perches
2012-01-05 8:22 ` Kalle Valo [this message]
2012-01-05 10:41 ` David Laight
2012-01-05 16:30 ` Joe Perches
2012-01-04 23:10 ` [PATCH 6/6] ath6kl: create ath6kl_core.ko Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F055DC8.9050902@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).