From: "Franky Lin" <frankyl@broadcom.com>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "Arend Van Spriel" <arend@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] brcmfmac: use existing net_device_stats
Date: Fri, 6 Jan 2012 12:07:51 -0800 [thread overview]
Message-ID: <4F075497.9070607@broadcom.com> (raw)
In-Reply-To: <20120105210001.600aacd3@nehalam.linuxnetplumber.net>
On 01/05/2012 09:00 PM, Stephen Hemminger wrote:
> You are confused. The only place the data in question is used is:
> static struct net_device_stats *brcmf_netdev_get_stats
>
> This is a per-network device standard API and it returns per-network device
> statistics. Several releases ago, structure element was added to the network_device
> struct for common usage by drivers. All this patch does is use that instead of the
> private device scratch pad.
>
> If you really want to be more clever, the device should be convert to the
> new getstats64 API, but that requires more work (like wrapping updates with
> the u64_stats_sync() macros.
>
I misunderstood since the first mail I got of this thread is Arend's
reply. But I did receive the "brcmf: make net_device_ops const" patch.
Something wrong with the mail server?
Franky
prev parent reply other threads:[~2012-01-06 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120105183947.295358582@vyatta.com>
2012-01-05 18:39 ` [PATCH 1/3] ath6kl: make net_device_ops const Stephen Hemminger
2012-01-09 14:40 ` Kalle Valo
2012-01-05 18:39 ` [PATCH 1/2] brcmf: " Stephen Hemminger
[not found] ` <20120105184000.572918423@vyatta.com>
2012-01-05 19:12 ` [PATCH 2/2] brcmfmac: use existing net_device_stats Arend van Spriel
2012-01-05 19:15 ` Stephen Hemminger
2012-01-05 19:39 ` Franky Lin
2012-01-06 5:00 ` Stephen Hemminger
2012-01-06 20:07 ` Franky Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F075497.9070607@broadcom.com \
--to=frankyl@broadcom.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).