* [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t
@ 2012-01-03 9:58 Vasanthakumar Thiagarajan
2012-01-09 10:46 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Vasanthakumar Thiagarajan @ 2012-01-03 9:58 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, ath6kl-devel
Otherwise if (ielen <= ATH6KL_MAX_IE) is dead code. It looks safe to
change the type of ielen from u8 to size_t instead of removing this
if check, this ielen can have the length of more than one ies in future.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index c44eca2..347e987 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -53,7 +53,7 @@ struct ath6kl_sta *ath6kl_find_sta_by_aid(struct ath6kl *ar, u8 aid)
}
static void ath6kl_add_new_sta(struct ath6kl *ar, u8 *mac, u16 aid, u8 *wpaie,
- u8 ielen, u8 keymgmt, u8 ucipher, u8 auth)
+ size_t ielen, u8 keymgmt, u8 ucipher, u8 auth)
{
struct ath6kl_sta *sta;
u8 free_slot;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t
2012-01-03 9:58 [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t Vasanthakumar Thiagarajan
@ 2012-01-09 10:46 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2012-01-09 10:46 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless, ath6kl-devel
On 01/03/2012 11:58 AM, Vasanthakumar Thiagarajan wrote:
> Otherwise if (ielen <= ATH6KL_MAX_IE) is dead code. It looks safe to
> change the type of ielen from u8 to size_t instead of removing this
> if check, this ielen can have the length of more than one ies in future.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Thanks, applied.
Kalle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-09 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 9:58 [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t Vasanthakumar Thiagarajan
2012-01-09 10:46 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).