From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Thirumalai <tpachamu@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>,
ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH 2/4] ath6kl: Introduce new queue for uAPSD.
Date: Mon, 9 Jan 2012 13:40:15 +0200 [thread overview]
Message-ID: <4F0AD21F.8000204@qca.qualcomm.com> (raw)
In-Reply-To: <1326095120-1603-1-git-send-email-tpachamu@qca.qualcomm.com>
On 01/09/2012 09:45 AM, Thirumalai wrote:
> Add apsd_info in necessary places to indicate which
> AC's uAPSD is enabled.
>
> A bit is added in the wmi header (bit 4 of info3)
> to specify uapsd trigger in rx direction (target to host)
> and end of service period in tx direction (host to target)
>
> Signed-off-by: Thirumalai <tpachamu@qca.qualcomm.com>
[...]
> +static inline void wmi_data_hdr_set_more_bit(struct wmi_data_hdr *dhdr)
> +{
> + dhdr->info |= (WMI_DATA_HDR_MORE_MASK << WMI_DATA_HDR_MORE_SHIFT);
> +}
> +
> +static inline void wmi_data_hdr_set_eosp_bit(struct wmi_data_hdr *dhdr)
> +{
> + dhdr->info3 |= (WMI_DATA_HDR_EOSP_MASK << WMI_DATA_HDR_EOSP_SHIFT);
> +}
I only see one caller for these functions so it's better to copy the
code to the caller directly and not have any extra functions.
Kalle
next prev parent reply other threads:[~2012-01-09 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 7:45 [PATCH 2/4] ath6kl: Introduce new queue for uAPSD Thirumalai
2012-01-09 11:40 ` Kalle Valo [this message]
2012-01-11 12:27 ` Kalle Valo
2012-01-12 5:25 ` Pachamuthu, Thirumalai
2012-01-12 11:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0AD21F.8000204@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tpachamu@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).