From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 0/8] Allow the user to define suspend mode
Date: Mon, 9 Jan 2012 19:52:06 +0200 [thread overview]
Message-ID: <4F0B2946.4040503@qca.qualcomm.com> (raw)
In-Reply-To: <1326098182-9103-1-git-send-email-rmani@qca.qualcomm.com>
On 01/09/2012 10:36 AM, rmani@qca.qualcomm.com wrote:
> This series of patch enables the user to specify the suspend mode
> via module parameter (suspend_mode) while doing insmod of the driver.
>
> To select Cut Power mode:
> insmod ath6kl_sdio.ko suspend_mode = 1
>
> To select Deep Sleep mode:
> insmod ath6kl_sdio.ko suspend_mode = 2
>
> To select WOW suspend mode:
> insmod ath6kl_sdio.ko suspend_mode = 3
>
> Existing module param 'suspend_cutpower' variable is renamed to
> 'suspend_mode' for this purspose.
I'm not sure about this one. In a way this makes sense so that user can
force the particular suspend mode, but on the other hand I'm not sure if
this is a bit too much.
J&J (John and Johannes), what do you think? Is this acceptable?
Kalle
prev parent reply other threads:[~2012-01-09 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 8:36 [PATCH 0/8] Allow the user to define suspend mode rmani
2012-01-09 8:36 ` [PATCH 1/8] ath6kl: Rename modparam variable suspend_cutpower to suspend_mode rmani
2012-01-09 19:20 ` Kalle Valo
2012-01-09 8:36 ` [PATCH 2/8] ath6kl: Re-architect suspend mode handling in ath6kl_sdio_suspend() rmani
2012-01-09 19:30 ` Kalle Valo
2012-01-09 8:36 ` [PATCH 3/8] ath6kl: Add a new func to configure default WOW patterns for AP mode rmani
2012-01-09 8:36 ` [PATCH 4/8] ath6kl: Add a new func to config default WOW patterns for non " rmani
2012-01-09 8:36 ` [PATCH 5/8] ath6kl: Move WOW patterns config code to a separate function rmani
2012-01-09 8:36 ` [PATCH 6/8] ath6kl: Configure WOW patterns while going to wow_suspend rmani
2012-01-09 8:36 ` [PATCH 7/8] ath6kl: Removed unused ATH6KL_CONF_SUSPEND_CUTPOWER macro rmani
2012-01-09 19:45 ` Kalle Valo
2012-01-09 8:36 ` [PATCH 8/8] ath6kl: Return a proper error code when not in connected state rmani
2012-01-09 17:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B2946.4040503@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).