From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH 2/8] ath6kl: Re-architect suspend mode handling in ath6kl_sdio_suspend()
Date: Mon, 9 Jan 2012 21:30:17 +0200 [thread overview]
Message-ID: <4F0B4049.4070306@qca.qualcomm.com> (raw)
In-Reply-To: <1326098182-9103-3-git-send-email-rmani@qca.qualcomm.com>
On 01/09/2012 10:36 AM, rmani@qca.qualcomm.com wrote:
> From: Raja Mani <rmani@qca.qualcomm.com>
>
> Dynamic suspend mode selection logic based on the host sdio
> controller capability (MMC_PM_KEEP_POWER and MMC_PM_WAKE_SDIO_IRQ)
> is completely removed.
What's the reason for this change? This loses all the automatic
detection we have. I would hope that we could keep the existing
detection capability and use the module parameter to override the
detection logic or something like that.
The driver should be as automatic as possible and the suspend_mode
module parameter should be used to override something.
> Additionally, new logic is added to have backup retry.
> In other words, If the driver fails to enter into either
> WOW (or) DEEP SLEEP mode, it would give a try in CUT POWER mode.
So the function now has a loop. To me that sounds very confusing and
error prone. What's the reason for this?
Kalle
next prev parent reply other threads:[~2012-01-09 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 8:36 [PATCH 0/8] Allow the user to define suspend mode rmani
2012-01-09 8:36 ` [PATCH 1/8] ath6kl: Rename modparam variable suspend_cutpower to suspend_mode rmani
2012-01-09 19:20 ` Kalle Valo
2012-01-09 8:36 ` [PATCH 2/8] ath6kl: Re-architect suspend mode handling in ath6kl_sdio_suspend() rmani
2012-01-09 19:30 ` Kalle Valo [this message]
2012-01-09 8:36 ` [PATCH 3/8] ath6kl: Add a new func to configure default WOW patterns for AP mode rmani
2012-01-09 8:36 ` [PATCH 4/8] ath6kl: Add a new func to config default WOW patterns for non " rmani
2012-01-09 8:36 ` [PATCH 5/8] ath6kl: Move WOW patterns config code to a separate function rmani
2012-01-09 8:36 ` [PATCH 6/8] ath6kl: Configure WOW patterns while going to wow_suspend rmani
2012-01-09 8:36 ` [PATCH 7/8] ath6kl: Removed unused ATH6KL_CONF_SUSPEND_CUTPOWER macro rmani
2012-01-09 19:45 ` Kalle Valo
2012-01-09 8:36 ` [PATCH 8/8] ath6kl: Return a proper error code when not in connected state rmani
2012-01-09 17:52 ` [PATCH 0/8] Allow the user to define suspend mode Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B4049.4070306@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).