From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Thirumalai <tpachamu@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>,
ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH 3/4] ath6kl: Add uAPSD support in rx path.
Date: Wed, 11 Jan 2012 15:15:59 +0200 [thread overview]
Message-ID: <4F0D8B8F.1050105@qca.qualcomm.com> (raw)
In-Reply-To: <1326095135-1633-1-git-send-email-tpachamu@qca.qualcomm.com>
On 01/09/2012 09:45 AM, Thirumalai wrote:
> + ath6kl_wmi_set_pvb_cmd(ar->wmi, vif->fw_vif_idx, conn->aid, 0);
> + if (is_apsdq_empty_at_start) {
> + ath6kl_wmi_set_apsd_bfrd_traf(ar->wmi,
> + vif->fw_vif_idx,
> + conn->aid, 0,
> + WMI_AP_APSD_NO_DELIVERY_FRAMES);
> + } else {
> + ath6kl_wmi_set_apsd_bfrd_traf(ar->wmi,
> + vif->fw_vif_idx,
> + conn->aid, 0, 0);
> + }
To have only one call to ath6kl_wmi_set_apsd_bfrd_traf() you could add a
variable like this:
u32 flags;
....
if (is_apsdq_empty_at_start)
flags = WMI_AP_APSD_NO_DELIVERY_FRAMES;
else
flags = 0;
ath6kl_wmi_set_pvb_cmd(ar->wmi, vif->fw_vif_idx, conn->aid, 0);
ath6kl_wmi_set_apsd_bfrd_traf(ar->wmi,
vif->fw_vif_idx,
conn->aid, 0, flags);
Kalle
prev parent reply other threads:[~2012-01-11 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 7:45 [PATCH 3/4] ath6kl: Add uAPSD support in rx path Thirumalai
2012-01-11 12:55 ` Kalle Valo
2012-01-11 13:15 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D8B8F.1050105@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tpachamu@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).