* [PATCH] carl9170: claim to support IBSS RSN.
@ 2012-01-11 15:44 Nicolas Cavallari
2012-01-11 16:13 ` Christian Lamparter
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Cavallari @ 2012-01-11 15:44 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Christian Lamparter, Nicolas Cavallari
On carl9170, HW encryption is disabled on IBSS; the mac80211
software-based encryption is used instead. As mac80211 supports IBSS
RSN (per-STA GTK), claim its support in the carl9170 PHY.
Signed-off-by: Nicolas Cavallari <cavallar@lri.fr>
---
drivers/net/wireless/ath/carl9170/main.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index f06e069..24c7f85 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -1796,6 +1796,9 @@ void *carl9170_alloc(size_t priv_size)
ar->noise[i] = -95; /* ATH_DEFAULT_NOISE_FLOOR */
hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+
+ /* As IBSS Encryption is software-based, IBSS RSN is supported. */
+ hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
return ar;
err_nomem:
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] carl9170: claim to support IBSS RSN.
2012-01-11 15:44 [PATCH] carl9170: claim to support IBSS RSN Nicolas Cavallari
@ 2012-01-11 16:13 ` Christian Lamparter
2012-01-12 10:09 ` Nicolas Cavallari
0 siblings, 1 reply; 3+ messages in thread
From: Christian Lamparter @ 2012-01-11 16:13 UTC (permalink / raw)
To: Nicolas Cavallari; +Cc: John W. Linville, linux-wireless, Nicolas Cavallari
On Wednesday, January 11, 2012 04:44:50 PM Nicolas Cavallari wrote:
> On carl9170, HW encryption is disabled on IBSS; the mac80211
> software-based encryption is used instead. As mac80211 supports IBSS
> RSN (per-STA GTK), claim its support in the carl9170 PHY.
Uh, was IBSS RSN fixed? Sure, if it works, why not.
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
> Signed-off-by: Nicolas Cavallari <cavallar@lri.fr>
> ---
> drivers/net/wireless/ath/carl9170/main.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
> index f06e069..24c7f85 100644
> --- a/drivers/net/wireless/ath/carl9170/main.c
> +++ b/drivers/net/wireless/ath/carl9170/main.c
> @@ -1796,6 +1796,9 @@ void *carl9170_alloc(size_t priv_size)
> ar->noise[i] = -95; /* ATH_DEFAULT_NOISE_FLOOR */
>
> hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> +
> + /* As IBSS Encryption is software-based, IBSS RSN is supported. */
> + hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
> return ar;
>
> err_nomem:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] carl9170: claim to support IBSS RSN.
2012-01-11 16:13 ` Christian Lamparter
@ 2012-01-12 10:09 ` Nicolas Cavallari
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Cavallari @ 2012-01-12 10:09 UTC (permalink / raw)
To: Christian Lamparter; +Cc: Nicolas Cavallari, John W. Linville, linux-wireless
On 11/01/2012 17:13, Christian Lamparter wrote:
> On Wednesday, January 11, 2012 04:44:50 PM Nicolas Cavallari wrote:
>> On carl9170, HW encryption is disabled on IBSS; the mac80211
>> software-based encryption is used instead. As mac80211 supports IBSS
>> RSN (per-STA GTK), claim its support in the carl9170 PHY.
>
> Uh, was IBSS RSN fixed? Sure, if it works, why not.
>
Fixed or not, it works for me and anyway there is this code in
ieee80211_alloc_hw() :
207aba60 573) if (!ops->set_key)
207aba60 574) wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
Which enables IBSS RSN on all SW-crypto-only devices.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-12 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 15:44 [PATCH] carl9170: claim to support IBSS RSN Nicolas Cavallari
2012-01-11 16:13 ` Christian Lamparter
2012-01-12 10:09 ` Nicolas Cavallari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).