From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Thirumalai Pachamuthu <tpachamu@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH v2] ath6kl: Add support for uAPSD
Date: Fri, 13 Jan 2012 19:25:12 +0200 [thread overview]
Message-ID: <4F1068F8.8040800@qca.qualcomm.com> (raw)
In-Reply-To: <4F101AA9.90004@qca.qualcomm.com>
On 01/13/2012 01:51 PM, Kalle Valo wrote:
>> +static bool ath6kl_process_uapsdq(struct ath6kl_sta *conn,
>> > + struct ath6kl_vif *vif,
>> > + struct sk_buff *skb,
>> > + u32 *flags)
>> > +{
>> > + struct ath6kl *ar = vif->ar;
>> > + bool is_apsdq_empty = false;
>> > + struct ethhdr *datap = (struct ethhdr *) skb->data;
>> > + u8 up = 0;
>
> This is initilised in an else branch I added below.
This actually creates a compiler warning which I missed. I'll send a
separate patch which reverts up initilisation back to the original.
Kalle
prev parent reply other threads:[~2012-01-13 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 12:51 [PATCH v2] ath6kl: Enable uAPSD support in AP mode Thirumalai Pachamuthu
2012-01-12 12:51 ` [PATCH v2] ath6kl: Add support for uAPSD Thirumalai Pachamuthu
2012-01-13 11:51 ` Kalle Valo
2012-01-13 17:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1068F8.8040800@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tpachamu@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).