* [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()
@ 2012-01-12 9:31 rmani
2012-01-13 11:54 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: rmani @ 2012-01-12 9:31 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Raja Mani
From: Raja Mani <rmani@qca.qualcomm.com>
ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
at the time of declaration. Later, return value of ath6kl_diag_read32()
repalces the init value. Hence removing useless zero assignment.
Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index eea3c74..51baec4 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -252,7 +252,7 @@ int ath6kl_read_fwlogs(struct ath6kl *ar)
struct ath6kl_dbglog_hdr debug_hdr;
struct ath6kl_dbglog_buf debug_buf;
u32 address, length, dropped, firstbuf, debug_hdr_addr;
- int ret = 0, loop;
+ int ret, loop;
u8 *buf;
buf = kmalloc(ATH6KL_FWLOG_PAYLOAD_SIZE, GFP_KERNEL);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()
2012-01-12 9:31 [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs() rmani
@ 2012-01-13 11:54 ` Kalle Valo
2012-01-18 5:53 ` Raja Mani
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2012-01-13 11:54 UTC (permalink / raw)
To: rmani; +Cc: linux-wireless, ath6kl-devel
On 01/12/2012 11:31 AM, rmani@qca.qualcomm.com wrote:
> From: Raja Mani <rmani@qca.qualcomm.com>
>
> ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
> at the time of declaration. Later, return value of ath6kl_diag_read32()
> repalces the init value. Hence removing useless zero assignment.
>
> Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
Thanks, applied.
BTW, I only got patch 1/2. What happened to patch 2?
Kalle
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()
2012-01-13 11:54 ` Kalle Valo
@ 2012-01-18 5:53 ` Raja Mani
0 siblings, 0 replies; 3+ messages in thread
From: Raja Mani @ 2012-01-18 5:53 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath6kl-devel
On Friday 13 January 2012 05:24 PM, Kalle Valo wrote:
> On 01/12/2012 11:31 AM, rmani@qca.qualcomm.com wrote:
>> From: Raja Mani<rmani@qca.qualcomm.com>
>>
>> ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
>> at the time of declaration. Later, return value of ath6kl_diag_read32()
>> repalces the init value. Hence removing useless zero assignment.
>>
>> Signed-off-by: Raja Mani<rmani@qca.qualcomm.com>
>
> Thanks, applied.
>
> BTW, I only got patch 1/2. What happened to patch 2?
Oops, I wanted to send only this patch.
It's a title mistake. Sorry about that.
>
> Kalle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-18 5:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 9:31 [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs() rmani
2012-01-13 11:54 ` Kalle Valo
2012-01-18 5:53 ` Raja Mani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).