From: Johannes Berg <johannes@sipsolutions.net>
To: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Do not scan for IBSS merge with a fixed BSSID.
Date: Fri, 27 Jan 2012 20:39:50 -0800 [thread overview]
Message-ID: <4F237C16.5050100@sipsolutions.net> (raw)
In-Reply-To: <1327581394-15368-1-git-send-email-cavallar@lri.fr> (sfid-20120126_133659_805161_39F32A75)
On 1/26/2012 4:36 AM, Nicolas Cavallari wrote:
> - if (ifibss->fixed_channel)
> + if (ifibss->fixed_bssid)
> return;
>
> printk(KERN_DEBUG "%s: No active IBSS STAs - trying to scan for other "
> "IBSS networks with same SSID (merge)\n", sdata->name);
Just from the looks of it, this doesn't seem right. If you're fixing the
BSSID, you're still asking for automatic channel selection and merging
with other peers using the same BSSID on different channels, so I
disagree with your commit message quite completely.
johannes
next prev parent reply other threads:[~2012-01-28 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 12:36 [PATCH] mac80211: Do not scan for IBSS merge with a fixed BSSID Nicolas Cavallari
2012-01-28 4:39 ` Johannes Berg [this message]
2012-01-30 8:54 ` Nicolas Cavallari
2012-01-30 14:51 ` Johannes Berg
2012-01-30 0:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F237C16.5050100@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Nicolas.Cavallari@lri.fr \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).