* [PATCH] mwl8k: Configuring correct MAC address in broadcast key
@ 2012-01-27 13:04 Yogesh Ashok Powar
2012-01-30 17:25 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Yogesh Ashok Powar @ 2012-01-27 13:04 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Lennert Buytenhek
While configuring the broadcast key in the hardware, in
multi-BSS environment, BSSes other than first were
incorrectly configured with the MAC address of first
BSS. Fixing it with correct MAC addresses.
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
---
(resent to include the linux-wireless list)
drivers/net/wireless/mwl8k.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index dd5aeaf..fd12547 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -4093,7 +4093,7 @@ static int mwl8k_set_key(struct ieee80211_hw *hw,
return -EOPNOTSUPP;
if (sta == NULL)
- addr = hw->wiphy->perm_addr;
+ addr = vif->addr;
else
addr = sta->addr;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mwl8k: Configuring correct MAC address in broadcast key
2012-01-27 13:04 [PATCH] mwl8k: Configuring correct MAC address in broadcast key Yogesh Ashok Powar
@ 2012-01-30 17:25 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2012-01-30 17:25 UTC (permalink / raw)
To: Yogesh Ashok Powar; +Cc: John W. Linville, linux-wireless, Lennert Buytenhek
Hello,
On 01/27/12 14:04, Yogesh Ashok Powar wrote:
> While configuring the broadcast key in the hardware, in
> multi-BSS environment, BSSes other than first were
> incorrectly configured with the MAC address of first
> BSS. Fixing it with correct MAC addresses.
>
> Signed-off-by: Yogesh Ashok Powar<yogeshp@marvell.com>
> ---
> (resent to include the linux-wireless list)
You might want to get this fix included for the stable 3.0, 3.1 and 3.2
releases since mwl8k_set_key() was introduced in 2.6.39 with:
fcdc403c31ed5bb5f3baf42f4e2b5e7198fef0c0: mwl8k: Enable HW encryption
for AP mode
>
>
> drivers/net/wireless/mwl8k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
> index dd5aeaf..fd12547 100644
> --- a/drivers/net/wireless/mwl8k.c
> +++ b/drivers/net/wireless/mwl8k.c
> @@ -4093,7 +4093,7 @@ static int mwl8k_set_key(struct ieee80211_hw *hw,
> return -EOPNOTSUPP;
>
> if (sta == NULL)
> - addr = hw->wiphy->perm_addr;
> + addr = vif->addr;
> else
> addr = sta->addr;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-30 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-27 13:04 [PATCH] mwl8k: Configuring correct MAC address in broadcast key Yogesh Ashok Powar
2012-01-30 17:25 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).