From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Devendra.Naga" <devendra.aaru@gmail.com>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
Date: Mon, 30 Jan 2012 17:35:41 -0600 [thread overview]
Message-ID: <4F27294D.30302@lwfinger.net> (raw)
In-Reply-To: <1327927591-28070-1-git-send-email-devendra.aaru@gmail.com>
On 01/30/2012 06:46 AM, Devendra.Naga wrote:
> From: "Devendra.Naga"<devendra.aaru@gmail.com>
>
> the return value from _rtl_pci_switch_clk_req is not used by any of its callers.
>
> Signed-off-by: Devendra.Naga<devendra.aaru@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
The patch is OK, but the patch subject is bad. You should have "[PATCH]
rtlwifi:...". Your patch is for rtlwifi, not wireless.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 4326fd1..35f4a0d 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
> }
>
> /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
> -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> {
> struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
> struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
> @@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
> udelay(100);
>
> - return true;
> }
>
> /*Disable RTL8192SE ASPM& Disable Pci Bridge ASPM*/
next prev parent reply other threads:[~2012-01-30 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:46 [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req Devendra.Naga
2012-01-30 23:35 ` Larry Finger [this message]
2012-01-30 23:45 ` Joe Perches
2012-01-31 6:22 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F27294D.30302@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=devendra.aaru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).