Re: [PATCH] ath6kl: Check wow state before sending control and data pkt

[Kalle Valo <kvalo@qca.qualcomm.com>]

On 02/06/2012 03:56 PM, rmani@qca.qualcomm.com wrote:
> From: Raja Mani <rmani@qca.qualcomm.com>
> 
> * TX operation (ctrl tx and data tx) has to be controlled based on
>   WOW suspend state. i.e, control packets are allowed to send from
>   the host until the suspend state goes ATH6KL_STATE_WOW and
>   the data packets are allowed until WOW suspend operation starts.
> 
> * Similary, wow resume is NOT allowed if WOW suspend is in progress.
> 
> Both of the above scenarios are taken care in this patch.
> 
> Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>

[...]

> +enum ath6kl_wow_state {
> +	ATH6KL_WOW_STATE_NONE,
> +	ATH6KL_WOW_STATE_SUSPENDING,
> +	ATH6KL_WOW_STATE_SUSPENDED,
> +};
> +
>  struct ath6kl {
>  	struct device *dev;
>  	struct wiphy *wiphy;
>  
>  	enum ath6kl_state state;
> +	enum ath6kl_wow_state wow_state;
>  	unsigned int testmode;

To be honest, adding a new state variable scares me. I don't see how we
are able to maintain two different state variables, the end result would
be a total mess.

I recommend to look at this problem by adding a new state to enum
ath6kl_state. That would make it a lot easier to handle all the
different states.

(I haven't looked rest of your patch yet.)

Kalle