linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Calling make directly is not permitted
@ 2012-02-06 15:38 Rick Farina
  2012-02-06 15:52 ` Richard Farina
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rick Farina @ 2012-02-06 15:38 UTC (permalink / raw)
  To: mcgrof; +Cc: linux-wireless, Rick Farina

make was being called directly, fix to $(MAKE)

Signed-of-By: Rick Farina <sidhayn@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index d586f45..440bd91 100644
--- a/Makefile
+++ b/Makefile
@@ -115,7 +115,7 @@ btuninstall:
 	@echo
 
 btclean:
-	make -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
+	$(MAKE) -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
 	@rm -f $(CREL_PRE)*
 
 install: uninstall install-modules install-scripts
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Calling make directly is not permitted
  2012-02-06 15:38 [PATCH] Calling make directly is not permitted Rick Farina
@ 2012-02-06 15:52 ` Richard Farina
  2012-02-06 16:03 ` Larry Finger
  2012-02-07 21:55 ` Luis R. Rodriguez
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Farina @ 2012-02-06 15:52 UTC (permalink / raw)
  To: mcgrof; +Cc: linux-wireless

On 02/06/12 10:38, Rick Farina wrote:

I apologize, both this patch and my "add missing =y" patch should have
had compat-wireless in the subject line. I'm still learning to use git
send-email.

Anyone want to tell me how to make git stop add myself to the cc just
because the SOB line is in the commit message? Am I supposed to add the
SOB some other way?

Thanks!

-Rick
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index d586f45..440bd91 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -115,7 +115,7 @@ btuninstall:
>  	@echo
>  
>  btclean:
> -	make -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
> +	$(MAKE) -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
>  	@rm -f $(CREL_PRE)*
>  
>  install: uninstall install-modules install-scripts


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Calling make directly is not permitted
  2012-02-06 15:38 [PATCH] Calling make directly is not permitted Rick Farina
  2012-02-06 15:52 ` Richard Farina
@ 2012-02-06 16:03 ` Larry Finger
  2012-02-07 21:55 ` Luis R. Rodriguez
  2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2012-02-06 16:03 UTC (permalink / raw)
  To: Rick Farina; +Cc: mcgrof, linux-wireless

On 02/06/2012 09:38 AM, Rick Farina wrote:
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina<sidhayn@gmail.com>
> ---
>   Makefile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

In your subject line, please indicate what component is being patched. From the 
context, I think it is compat-wireless, but why should I have to guess?

Larry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Calling make directly is not permitted
  2012-02-06 15:38 [PATCH] Calling make directly is not permitted Rick Farina
  2012-02-06 15:52 ` Richard Farina
  2012-02-06 16:03 ` Larry Finger
@ 2012-02-07 21:55 ` Luis R. Rodriguez
  2 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2012-02-07 21:55 UTC (permalink / raw)
  To: Rick Farina; +Cc: linux-wireless

On Mon, Feb 6, 2012 at 7:38 AM, Rick Farina <sidhayn@gmail.com> wrote:
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>

applied and pushed, thanks!

  Luis

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-07 21:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-06 15:38 [PATCH] Calling make directly is not permitted Rick Farina
2012-02-06 15:52 ` Richard Farina
2012-02-06 16:03 ` Larry Finger
2012-02-07 21:55 ` Luis R. Rodriguez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).