[PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

[PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

[Rick Farina]

When editing config.mk with a sed script the missing =y on this line
causes issue. Since this line is commented out by default this means no
changes to the default behavior and sed scripts will be able to edit the
config.mk file much more easily.

Signed-of-By: Rick Farina <sidhayn@gmail.com>
---
 config.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/config.mk b/config.mk
index 9433ce9..a9d189e 100644
--- a/config.mk
+++ b/config.mk
@@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
 endif #CONFIG_LEDS_CLASS
 endif #CONFIG_COMPAT_KERNEL_2_6_25
 # CONFIG_RT2X00_DEBUG=y
-# CONFIG_RT2X00_LIB_DEBUGFS
+# CONFIG_RT2X00_LIB_DEBUGFS=y
 endif
 
 # p54
-- 
1.7.3.4

Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

[John W. Linville]

On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
> 
> Signed-of-By: Rick Farina <sidhayn@gmail.com>
> ---
>  config.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/config.mk b/config.mk
> index 9433ce9..a9d189e 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
>  endif #CONFIG_LEDS_CLASS
>  endif #CONFIG_COMPAT_KERNEL_2_6_25
>  # CONFIG_RT2X00_DEBUG=y
> -# CONFIG_RT2X00_LIB_DEBUGFS
> +# CONFIG_RT2X00_LIB_DEBUGFS=y
>  endif
>  
>  # p54

Isn't it more common to say "is not set" for Kconfig stuff that is commented out?

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

[Richard Farina]

On 02/06/12 11:16, John W. Linville wrote:
> On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
>> When editing config.mk with a sed script the missing =y on this line
>> causes issue. Since this line is commented out by default this means no
>> changes to the default behavior and sed scripts will be able to edit the
>> config.mk file much more easily.
>>
>> Signed-of-By: Rick Farina <sidhayn@gmail.com>
>> ---
>>  config.mk |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/config.mk b/config.mk
>> index 9433ce9..a9d189e 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
>>  endif #CONFIG_LEDS_CLASS
>>  endif #CONFIG_COMPAT_KERNEL_2_6_25
>>  # CONFIG_RT2X00_DEBUG=y
>> -# CONFIG_RT2X00_LIB_DEBUGFS
>> +# CONFIG_RT2X00_LIB_DEBUGFS=y
>>  endif
>>  
>>  # p54
> Isn't it more common to say "is not set" for Kconfig stuff that is commented out?
>
You are completely correct, however in this case that is not used on any
of the other lines.  This change makes the style consistent across
compat-wireless not across the kernel.

Thanks,
Rick

Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

[Luis R. Rodriguez]

On Mon, Feb 6, 2012 at 7:42 AM, Rick Farina <sidhayn@gmail.com> wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>

Applied and pushed, thanks!

  Luis