* [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS
@ 2012-02-06 15:42 Rick Farina
2012-02-06 16:16 ` John W. Linville
2012-02-07 21:57 ` Luis R. Rodriguez
0 siblings, 2 replies; 4+ messages in thread
From: Rick Farina @ 2012-02-06 15:42 UTC (permalink / raw)
To: mcgrof; +Cc: linux-wireless, Rick Farina
When editing config.mk with a sed script the missing =y on this line
causes issue. Since this line is commented out by default this means no
changes to the default behavior and sed scripts will be able to edit the
config.mk file much more easily.
Signed-of-By: Rick Farina <sidhayn@gmail.com>
---
config.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/config.mk b/config.mk
index 9433ce9..a9d189e 100644
--- a/config.mk
+++ b/config.mk
@@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
endif #CONFIG_LEDS_CLASS
endif #CONFIG_COMPAT_KERNEL_2_6_25
# CONFIG_RT2X00_DEBUG=y
-# CONFIG_RT2X00_LIB_DEBUGFS
+# CONFIG_RT2X00_LIB_DEBUGFS=y
endif
# p54
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS
2012-02-06 15:42 [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS Rick Farina
@ 2012-02-06 16:16 ` John W. Linville
2012-02-06 16:42 ` Richard Farina
2012-02-07 21:57 ` Luis R. Rodriguez
1 sibling, 1 reply; 4+ messages in thread
From: John W. Linville @ 2012-02-06 16:16 UTC (permalink / raw)
To: Rick Farina; +Cc: mcgrof, linux-wireless
On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>
> ---
> config.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index 9433ce9..a9d189e 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
> endif #CONFIG_LEDS_CLASS
> endif #CONFIG_COMPAT_KERNEL_2_6_25
> # CONFIG_RT2X00_DEBUG=y
> -# CONFIG_RT2X00_LIB_DEBUGFS
> +# CONFIG_RT2X00_LIB_DEBUGFS=y
> endif
>
> # p54
Isn't it more common to say "is not set" for Kconfig stuff that is commented out?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS
2012-02-06 16:16 ` John W. Linville
@ 2012-02-06 16:42 ` Richard Farina
0 siblings, 0 replies; 4+ messages in thread
From: Richard Farina @ 2012-02-06 16:42 UTC (permalink / raw)
To: John W. Linville; +Cc: mcgrof, linux-wireless
On 02/06/12 11:16, John W. Linville wrote:
> On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
>> When editing config.mk with a sed script the missing =y on this line
>> causes issue. Since this line is commented out by default this means no
>> changes to the default behavior and sed scripts will be able to edit the
>> config.mk file much more easily.
>>
>> Signed-of-By: Rick Farina <sidhayn@gmail.com>
>> ---
>> config.mk | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/config.mk b/config.mk
>> index 9433ce9..a9d189e 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
>> endif #CONFIG_LEDS_CLASS
>> endif #CONFIG_COMPAT_KERNEL_2_6_25
>> # CONFIG_RT2X00_DEBUG=y
>> -# CONFIG_RT2X00_LIB_DEBUGFS
>> +# CONFIG_RT2X00_LIB_DEBUGFS=y
>> endif
>>
>> # p54
> Isn't it more common to say "is not set" for Kconfig stuff that is commented out?
>
You are completely correct, however in this case that is not used on any
of the other lines. This change makes the style consistent across
compat-wireless not across the kernel.
Thanks,
Rick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS
2012-02-06 15:42 [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS Rick Farina
2012-02-06 16:16 ` John W. Linville
@ 2012-02-07 21:57 ` Luis R. Rodriguez
1 sibling, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2012-02-07 21:57 UTC (permalink / raw)
To: Rick Farina; +Cc: linux-wireless
On Mon, Feb 6, 2012 at 7:42 AM, Rick Farina <sidhayn@gmail.com> wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>
Applied and pushed, thanks!
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-07 21:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-06 15:42 [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS Rick Farina
2012-02-06 16:16 ` John W. Linville
2012-02-06 16:42 ` Richard Farina
2012-02-07 21:57 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).