* RTLWIFI_DEBUG bug
@ 2012-02-13 14:13 Johannes Berg
2012-02-13 20:35 ` Joe Perches
2012-02-13 21:45 ` Larry Finger
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2012-02-13 14:13 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-wireless
config RTLWIFI_DEBUG
tristate "Additional debugging output"
depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
default y
should be
config RTLWIFI_DEBUG
bool "..."
as otherwise
+#ifdef CONFIG_RTLWIFI_DEBUG
can never be true in a modular build.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RTLWIFI_DEBUG bug
2012-02-13 14:13 RTLWIFI_DEBUG bug Johannes Berg
@ 2012-02-13 20:35 ` Joe Perches
2012-02-13 21:07 ` Johannes Berg
2012-02-13 21:45 ` Larry Finger
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2012-02-13 20:35 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> config RTLWIFI_DEBUG
> tristate "Additional debugging output"
> depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> default y
>
> should be
>
> config RTLWIFI_DEBUG
> bool "..."
>
> as otherwise
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
> can never be true in a modular build.
If you know the correct solution,
perhaps you should submit a patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RTLWIFI_DEBUG bug
2012-02-13 20:35 ` Joe Perches
@ 2012-02-13 21:07 ` Johannes Berg
2012-02-14 1:48 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2012-02-13 21:07 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-wireless
On Mon, 2012-02-13 at 12:35 -0800, Joe Perches wrote:
> On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> > config RTLWIFI_DEBUG
> > tristate "Additional debugging output"
> > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > default y
> >
> > should be
> >
> > config RTLWIFI_DEBUG
> > bool "..."
> >
> > as otherwise
> >
> > +#ifdef CONFIG_RTLWIFI_DEBUG
> > can never be true in a modular build.
>
> If you know the correct solution,
> perhaps you should submit a patch.
If I knew your attitude was going to be a problem, I'd never said
anything. I have better things to do.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RTLWIFI_DEBUG bug
2012-02-13 21:07 ` Johannes Berg
@ 2012-02-14 1:48 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2012-02-14 1:48 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Mon, 2012-02-13 at 22:07 +0100, Johannes Berg wrote:
> On Mon, 2012-02-13 at 12:35 -0800, Joe Perches wrote:
> > On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> > > config RTLWIFI_DEBUG
> > > tristate "Additional debugging output"
> > > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > > default y
> > >
> > > should be
> > >
> > > config RTLWIFI_DEBUG
> > > bool "..."
> > >
> > > as otherwise
> > >
> > > +#ifdef CONFIG_RTLWIFI_DEBUG
> > > can never be true in a modular build.
> >
> > If you know the correct solution,
> > perhaps you should submit a patch.
>
> If I knew your attitude was going to be a problem, I'd never said
> anything. I have better things to do.
If you know a problem exists and the
proper solution, it's not necessary to
do anything other than create the
appropriate patch and cc the appropriate
people. Doing something else just creates
more work for more people.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RTLWIFI_DEBUG bug
2012-02-13 14:13 RTLWIFI_DEBUG bug Johannes Berg
2012-02-13 20:35 ` Joe Perches
@ 2012-02-13 21:45 ` Larry Finger
2012-02-14 7:36 ` Johannes Berg
1 sibling, 1 reply; 6+ messages in thread
From: Larry Finger @ 2012-02-13 21:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: Joe Perches, linux-wireless
On 02/13/2012 08:13 AM, Johannes Berg wrote:
> config RTLWIFI_DEBUG
> tristate "Additional debugging output"
> depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> default y
>
> should be
>
> config RTLWIFI_DEBUG
> bool "..."
>
> as otherwise
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
>
> can never be true in a modular build.
>
> johannes
Johannes,
It is OK as is. The appropriate section of my .config has
CONFIG_RTL8192CE=m
CONFIG_RTL8192SE=m
CONFIG_RTL8192DE=m
CONFIG_RTL8192CU=m
CONFIG_RTLWIFI=m
CONFIG_RTLWIFI_DEBUG=m
CONFIG_RTL8192C_COMMON=m
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RTLWIFI_DEBUG bug
2012-02-13 21:45 ` Larry Finger
@ 2012-02-14 7:36 ` Johannes Berg
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Berg @ 2012-02-14 7:36 UTC (permalink / raw)
To: Larry Finger; +Cc: Joe Perches, linux-wireless
On Mon, 2012-02-13 at 15:45 -0600, Larry Finger wrote:
> On 02/13/2012 08:13 AM, Johannes Berg wrote:
> > config RTLWIFI_DEBUG
> > tristate "Additional debugging output"
> > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > default y
> >
> > should be
> >
> > config RTLWIFI_DEBUG
> > bool "..."
> >
> > as otherwise
> >
> > +#ifdef CONFIG_RTLWIFI_DEBUG
> >
> > can never be true in a modular build.
> >
> > johannes
>
> Johannes,
>
> It is OK as is. The appropriate section of my .config has
>
> CONFIG_RTL8192CE=m
> CONFIG_RTL8192SE=m
> CONFIG_RTL8192DE=m
> CONFIG_RTL8192CU=m
> CONFIG_RTLWIFI=m
> CONFIG_RTLWIFI_DEBUG=m
Kconfig wise it is fine, but you might as well unset it -- the only use
is an #ifdef which will not match when it's set to m.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-14 7:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-13 14:13 RTLWIFI_DEBUG bug Johannes Berg
2012-02-13 20:35 ` Joe Perches
2012-02-13 21:07 ` Johannes Berg
2012-02-14 1:48 ` Joe Perches
2012-02-13 21:45 ` Larry Finger
2012-02-14 7:36 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).