From: Ben Greear <greearb@candelatech.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH 3/7] ath9k: Merge wiphy and misc debugfs files
Date: Mon, 13 Feb 2012 17:56:47 -0800 [thread overview]
Message-ID: <4F39BF5F.3030408@candelatech.com> (raw)
In-Reply-To: <20281.48485.409968.741657@gargle.gargle.HOWL>
On 02/13/2012 05:48 PM, Sujith Manoharan wrote:
> Ben Greear wrote:
>> It is nice to be able to see what the driver/NIC thinks
>> it is set to as well. It is always possible that the
>> stack and the NIC are out of sync for some reason.
>> I'd rather those values be left in the debugfs unless
>> there is a good reason for getting rid of them.
>
> The 'wiphy' file is a remnant from the old virtual HW code.
> To know the channel parameters of multiple, virtual PHYs, it
> was useful. Since the operating parameters, channel type, HT
> capabilites etc. are all exposed by mac80211's debugfs, we might
What if there is some bug that causes the NIC to be in a
state different than mac80211 thinks it is? If you leave
this in, then maybe someone will notice.
Ath9k is a tricky beast to debug, and I think you should
not remove anything that is remotely useful to debugging
unless removing it has a real benefit other than just
decreasing lines of (conditionally compiled) code.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-02-14 1:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 6:20 [PATCH 3/7] ath9k: Merge wiphy and misc debugfs files Sujith Manoharan
2012-02-13 17:25 ` Ben Greear
2012-02-14 1:48 ` Sujith Manoharan
2012-02-14 1:56 ` Ben Greear [this message]
2012-02-14 2:52 ` Sujith Manoharan
2012-02-14 7:38 ` [ath9k-devel] " Peter Stuge
2012-02-14 8:30 ` Sujith Manoharan
2012-02-14 17:32 ` Ben Greear
2012-02-14 18:29 ` Sujith
2012-02-14 18:43 ` Ben Greear
2012-02-14 22:29 ` Felix Fietkau
2012-02-14 22:41 ` Ben Greear
2012-02-15 4:47 ` Sujith Manoharan
2012-02-15 8:37 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F39BF5F.3030408@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).