Re: [RFT/FYI] mac80211: revert on-channel work optimisations

[Ben Greear <greearb@candelatech.com>]

On 02/17/2012 07:44 AM, Johannes Berg wrote:
> On Tue, 2011-11-08 at 09:17 -0800, Ben Greear wrote:
>> On 11/08/2011 09:10 AM, Johannes Berg wrote:
>>> FYI -- I'm going to test this a bit more but I am going to put it in.
>>> The code is a mess -- look at how much code I remove below (and that's
>>> after everybody elses cleanups!) for a dubious optimisation.
>>>
>>> I agree that we should address this and we need to really do this to not
>>> mess up our aggregation state, but the current code is too complex and
>>> causing too many issues. We also need to think about this in the context
>>> of multi-virtual-channel support.
>>
>> Well crap.  Why don't you try to fix it right instead?
>>
>> I'll probably end up carrying this in my own tree so
>> that multiple vifs work well and don't constantly
>> reset the ath9k causing it to shit itself...
>
> Given the auth/assoc redesign that went in now, are you still carrying
> this? Does the redesign address your problem?

I haven't looked yet...still stuck back on 3.0 kernel for the
most part.

I should be moving to 3.3 sometime soon, and will see how it works.

I was thinking that I would ignore the work logic for now and probably
just focus on re-applying the on-channel scan optimization first.

Are you done, or mostly done with the re-architecture you were working on?

I know you didn't like the scan optimization from before...do you have any
ideas on how it might be done more to your liking?

Thanks,
Ben


>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com