Re: [RFC] use alternate SPROM offset for 43224

["Arend van Spriel" <arend@broadcom.com>]

On 02/19/2012 04:37 PM, Hauke Mehrtens wrote:
> On 02/14/2012 11:39 PM, Arend Van Spriel wrote:
>>> Sent: dinsdag 14 februari 2012 23:04
>>>
>>> On 02/14/2012 02:20 PM, Hauke Mehrtens wrote:
>>>>>>   I think it is more complicated than the above. On my 43224, I get
>>> the
>>>>>>   message "No SPROM available", which arises because
>>> bcma_sprom_get() is
>>>>>>   returning -ENOENT. The reason is that the value tested in "if
>>>>>>   (!(sromctrl&   BCMA_CC_SROM_CONTROL_PRESENT))" is zero. The
>>> contents of
>>>>>>   sromctl are 0x12, and the mask is 1.
>>>> This check is the main part of ai_is_sprom_available() in brcmsmac.
>>> If
>>>> this check fails, like in your case, brcmsmac tries otp_read_pci() to
>>>> read out the sprom, which is not implemented in bcma.
>>>
>>> I will try implementing a similar routine in bcma.
>>>
>>
>> I started adding proper OTP support in BCMA, but I am currently working on async firmware loading feature. Different chipsets can either have an external SPROM or on-chip OTP. Some have both, but only one holds the data.
>>
>> Gr. AvS
> Nice to hear you are working on OTP support in bcma. In that process,
> are you also working on making brcmsmac using the sprom provided by bcma?
>
> Hauke
>
>

Yep, no sense having it implemented in two places. I think I will do it 
in one patch series.

Gr. AvS