From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: David Miller <davem@davemloft.net>
Cc: andrei.emeltchenko.news@gmail.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2012-02-20
Date: Wed, 22 Feb 2012 11:07:55 +0100 [thread overview]
Message-ID: <4F44BE7B.8000501@neratec.com> (raw)
In-Reply-To: <20120221.154053.2103818562080068513.davem@davemloft.net>
On 02/21/2012 09:40 PM, David Miller wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
> Date: Tue, 21 Feb 2012 22:38:16 +0200
>
>> Hi David,
>>
>> On Tue, Feb 21, 2012 at 9:44 PM, David Miller <davem@davemloft.net> wrote:
>>> From: "John W. Linville" <linville@tuxdriver.com>
>>> Date: Tue, 21 Feb 2012 10:14:36 -0500
>>> [...]
>>
>> Sorry did we understand wrong text of Linux coding style? Or do we need
>> right interpretation of it?
>
> I'm not engaging in this conversation any more, I don't care what CodingStyle
> says, the quoted code is garbage.
This is not really helpful, David.
Andrei's question was fully reasonable here, i.e. the Documentation/CodingStyle is the only binding reference given to potential contributors -- the common 'how-to-contribute-kernel-patches' docs non-24/7-kernel-folks usually find and follow on the way preparing patches end exactly there.
I recently learned the hard way when my patches were ignored just because of some missing spaces. That would be perfectly fair if some formal rules were broken, but not telling people about additional informal ones is not motivating.
I might be fully blind and just missed the related coding style document that covers the issues discussed here. But even then your answer should be 'RTFM' instead of just ending the conversation.
Cheers, Zefir
prev parent reply other threads:[~2012-02-22 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 20:37 pull request: wireless 2012-02-20 John W. Linville
2012-02-21 0:23 ` David Miller
2012-02-21 15:14 ` John W. Linville
2012-02-21 19:44 ` David Miller
2012-02-21 20:38 ` Andrei Emeltchenko
2012-02-21 20:40 ` David Miller
2012-02-21 20:59 ` [PATCH] checkpatch: Add some --strict coding style checks Joe Perches
2012-02-21 21:09 ` Andrew Morton
2012-02-21 21:11 ` Joe Perches
2012-02-21 22:09 ` Allan, Bruce W
2012-02-21 23:16 ` Joe Perches
2012-02-22 1:36 ` Joe Perches
2012-02-22 1:56 ` Allan, Bruce W
2012-02-22 1:58 ` Joe Perches
2012-02-22 2:17 ` Allan, Bruce W
2012-02-23 3:43 ` Joe Perches
2012-02-24 18:22 ` Allan, Bruce W
2012-02-24 18:37 ` [PATCH v2] " Joe Perches
2012-02-29 14:38 ` Kalle Valo
2012-02-22 9:35 ` [PATCH] " David Laight
2012-02-22 9:46 ` Johannes Berg
2012-02-22 10:07 ` Zefir Kurtisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F44BE7B.8000501@neratec.com \
--to=zefir.kurtisi@neratec.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).