From: "Arend van Spriel" <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"M. Lambert" <lambertm@westman.wave.ca>
Subject: Re: [PATCH 14/15] brcm80211: fmac: add USB support for bcm43235/6/8 chipsets
Date: Fri, 24 Feb 2012 10:47:05 +0100 [thread overview]
Message-ID: <4F475C99.2040802@broadcom.com> (raw)
In-Reply-To: <CACna6rw9jU0HOOVHKNzqMW8sRXFgOwbSw6iOri4oQ_uTVopafw@mail.gmail.com>
On 02/24/2012 07:16 AM, Rafał Miłecki wrote:
> W dniu 23 lutego 2012 22:20 użytkownik Arend van Spriel
> <arend@broadcom.com> napisał:
>> On 02/23/2012 07:46 PM, Rafał Miłecki wrote:
>>>
>>> W dniu 23 lutego 2012 19:10 użytkownik Rafał Miłecki<zajec5@gmail.com>
>>> napisał:
>>>>
>>>> 2012/2/9 Arend van Spriel<arend@broadcom.com>:
>>>>>
>>>>> This patch extends the use of the brcmfmac driver with support for
>>>>> chipsets with a USB host interface. The first chipsets supported are
>>>>> the bcm43235, bcm43236, and bcm43238 for which firmware has been
>>>>> submitted.
>>>>
>>>>
>>>> Can you say something more about the firmware? AFAICS brcm directory
>>>> in linux-firmware.git contains:
>>>> brcmfmac43236b.bin
>>>> brcmfmac4329.bin
>>>> brcmfmac4330.bin
>>>>
>>>>
>>>>> +#define BRCMF_USB_FW_NAME "brcm/brcmfmac-usb.bin"
>>>>
>>>>
>>>> However your driver seems to require *only* brcmfmac-usb.bin firmware
>>>> file...
>>>
>>>
>>> The only file passing usb.c::check_file test seems to be
>>> brcmfmac43236b.bin. I guess you meant this file name in usb.c.
>>>
>>
>> Yes. bcm4329 and bcm4330 are SDIO cards. I will update the information on
>> linuxwireless.
>
> I'm afraid we don't understand each other. The problem is that
> filename of firmware submitted to the linux-firmware.git doesn't match
> filename requested by brcmfmac/usb.c.
>
> brcmfmac43236b.bin != brcmfmac-usb.bin
>
I do understand and the instruction on linux-wireless says:
cp brcm/brcmfmac43236b.bin /lib/firmware/brcm/brcmfmac/brcmfmac-usb.bin
et voila, they match. However, I can follow the reasoning you gave in
your patch albeit unlikely that someone inserts two wireless dongles in
system.
Gr. AvS
next prev parent reply other threads:[~2012-02-24 9:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 20:08 [PATCH 00/15] brcm80211: resolve brcmsmac issues and brcmfmac usb support Arend van Spriel
2012-02-09 20:08 ` [PATCH 01/15] brcm80211: update the maintainers listed for brcm80211 drivers Arend van Spriel
2012-02-10 7:26 ` Rafał Miłecki
2012-02-09 20:08 ` [PATCH 02/15] brcm80211: smac: fix unintended fallthru in wlc_phy_radio_init_2057() Arend van Spriel
2012-02-09 20:08 ` [PATCH 03/15] brcm80211: smac: remove redundant assignments from txpwrctrl_pwr_setup_nphy Arend van Spriel
2012-02-09 20:08 ` [PATCH 04/15] brcm80211: smac: fix endless retry of A-MPDU transmissions Arend van Spriel
2012-02-09 20:08 ` [PATCH 05/15] brcm80211: smac: remove smatch warnings from brcmsmac code Arend van Spriel
2012-02-09 20:09 ` [PATCH 06/15] brcm80211: fmac: resolve smatch issues in brcmfmac code Arend van Spriel
2012-02-09 20:09 ` [PATCH 07/15] brcm80211: fmac: make sure cancel_work_sync only called after INIT_WORK Arend van Spriel
2012-02-09 20:09 ` [PATCH 08/15] brcm80211: fmac: use specific types in struct brcmf_bus Arend van Spriel
2012-02-09 20:09 ` [PATCH 09/15] brcm80211: fmac: move module entry points to dhd_linux.c Arend van Spriel
2012-02-09 23:50 ` Julian Calaby
2012-02-10 9:11 ` Arend van Spriel
2012-02-09 20:09 ` [PATCH 10/15] brcm80211: fmac: only return success in brcmf_sdbrcm_bus_init() when true Arend van Spriel
2012-02-09 20:09 ` [PATCH 11/15] brcm80211: fmac: update bus state in common driver part Arend van Spriel
2012-02-09 20:09 ` [PATCH 12/15] brcm80211: fmac: change allocation flag in brcmf_enq_event() function Arend van Spriel
2012-02-09 20:09 ` [PATCH 13/15] brcm80211: fmac: use spinlock calls saving irq flags in brcmf_enq_event() Arend van Spriel
2012-02-09 20:09 ` [PATCH 14/15] brcm80211: fmac: add USB support for bcm43235/6/8 chipsets Arend van Spriel
2012-02-23 18:10 ` Rafał Miłecki
2012-02-23 18:46 ` Rafał Miłecki
2012-02-23 21:20 ` Arend van Spriel
2012-02-24 6:16 ` Rafał Miłecki
2012-02-24 9:47 ` Arend van Spriel [this message]
2012-02-09 20:09 ` [PATCH 15/15] brcm80211: fmac: make sdio firmware filename specific Arend van Spriel
2012-02-22 17:12 ` [PATCH 00/15] brcm80211: resolve brcmsmac issues and brcmfmac usb support Arend van Spriel
2012-02-22 19:14 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F475C99.2040802@broadcom.com \
--to=arend@broadcom.com \
--cc=lambertm@westman.wave.ca \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).