From: "Arend van Spriel" <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Saul St. John" <saul.stjohn@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Larry Finger" <Larry.Finger@lwfinger.net>
Subject: Re: [RFC] bcma: add support for on-chip OTP memory used for SPROM storage
Date: Fri, 24 Feb 2012 11:39:12 +0100 [thread overview]
Message-ID: <4F4768D0.4030109@broadcom.com> (raw)
In-Reply-To: <CACna6rwk8xbjbX7uisqAv_y_JYn636orR-VLgNQ908yOYS+i1A@mail.gmail.com>
On 02/24/2012 08:52 AM, Rafał Miłecki wrote:
>> + srom_control = bcma_read32(bus->drv_cc.core,
>> > + BCMA_CC_SROM_CONTROL);
>> > + return !!(srom_control& BCMA_CC_SROM_CONTROL_PRESENT);
> Does any compiler complain on returning sth like 0xF as a bool?
>
The compiler probably will not complain, but the caller could have
following:
if (bcma_sprom_ext_available(bus) == true) {
return;
}
BUG();
I guess you would see the BUG show up in your log with the function
returning 0xF.
Gr. AvS
next prev parent reply other threads:[~2012-02-24 10:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 21:52 [RFC] bcma: add support for on-chip OTP memory used for SPROM storage Arend van Spriel
2012-02-24 2:42 ` Saul St. John
2012-02-24 9:55 ` Arend van Spriel
2012-02-24 7:52 ` Rafał Miłecki
2012-02-24 10:15 ` Arend van Spriel
2012-02-24 10:39 ` Arend van Spriel [this message]
2012-02-24 10:58 ` Johannes Berg
2012-02-24 11:18 ` Arend van Spriel
2012-02-25 12:52 ` Hauke Mehrtens
2012-02-25 14:29 ` Rafał Miłecki
2012-02-27 10:12 ` Arend van Spriel
2012-02-28 20:11 ` Hauke Mehrtens
2012-03-01 14:12 ` Arend van Spriel
2012-03-01 14:35 ` Hauke Mehrtens
2012-03-01 15:16 ` Arend van Spriel
2012-03-01 16:14 ` Hauke Mehrtens
2012-03-03 22:44 ` Rafał Miłecki
2012-03-05 9:16 ` Arend van Spriel
2012-03-06 8:52 ` Rafał Miłecki
2012-03-06 12:26 ` Arend van Spriel
2012-03-01 21:26 ` Arend van Spriel
2012-03-01 21:42 ` Larry Finger
2012-03-01 21:56 ` Hauke Mehrtens
2012-03-02 10:39 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4768D0.4030109@broadcom.com \
--to=arend@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=saul.stjohn@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).