From: Mahesh <maheshp@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Chakra Parvathaneni <chakra@posedge.com>
Subject: Re: [RFCv2] cfg80211: 80Mhz Bandwidth channel flags in 5Gig band
Date: Fri, 24 Feb 2012 16:51:15 +0530 [thread overview]
Message-ID: <4F4772AB.9000305@posedge.com> (raw)
In-Reply-To: <1330070145.3426.8.camel@jlt3.sipsolutions.net>
On 02/24/2012 01:25 PM, Johannes Berg wrote:
> On Fri, 2012-02-24 at 10:55 +0530, Mahesh wrote:
>
>> Agree. we will work towards updating regulatory database with 80Mhz
>> bandwidth in 5Gig band. I had modified code to check maximum bandwidth
>> as well. Please find the updated change below.
>
>> - if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(40))
>> - bw_flags = IEEE80211_CHAN_NO_HT40;
>> + if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(40)) {
>> + bw_flags = IEEE80211_CHAN_NO_HT40 | IEEE80211_CHAN_NO_VHT80;
>> + } else if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(80)) {
>> + bw_flags = IEEE80211_CHAN_NO_VHT80;
>> + }
>
> no braces needed
>
> Also this will always be true now, so the patch isn't very useful right
> now?
True. But once reg database reflects 80MHz BW, we need it. Anyways its
part of new feature. Not a bug fix.
>
>
>> - if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(40))
>> - bw_flags = IEEE80211_CHAN_NO_HT40;
>> + if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(40)) {
>> + bw_flags = IEEE80211_CHAN_NO_HT40 | IEEE80211_CHAN_NO_VHT80;
>> + } else if (freq_range->max_bandwidth_khz< MHZ_TO_KHZ(80)) {
>> + bw_flags = IEEE80211_CHAN_NO_VHT80;
>> + }
>
> Seems some refactoring could be useful since this is duplicated?
May be a macro?
>
> johannes
>
next prev parent reply other threads:[~2012-02-24 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 17:51 [RFC] cfg80211: 80Mhz Bandwidth channel flags in 5Gig band Mahesh
2012-02-22 17:57 ` Johannes Berg
2012-02-22 18:57 ` Johannes Berg
2012-02-24 5:25 ` [RFCv2] " Mahesh
2012-02-24 5:43 ` Adrian Chadd
2012-02-24 5:48 ` Mahesh
2012-02-24 8:01 ` Johannes Berg
2012-02-24 7:55 ` Johannes Berg
2012-02-24 11:21 ` Mahesh [this message]
2012-02-25 19:22 ` Adrian Chadd
2012-02-25 21:30 ` Johannes Berg
[not found] ` <eab3dfdc8ebc87ec08ca64db9f237d90@posedge.com>
2012-04-03 12:06 ` 802.11ac support Johannes Berg
2012-04-03 12:11 ` Johannes Berg
2012-04-05 4:21 ` Mahesh
2012-04-05 14:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4772AB.9000305@posedge.com \
--to=maheshp@posedge.com \
--cc=chakra@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).