From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH V2 3/5] ath6kl: Refactor ath6kl_wmi_control_rx()
Date: Tue, 28 Feb 2012 11:10:27 +0200 [thread overview]
Message-ID: <4F4C9A03.2080906@qca.qualcomm.com> (raw)
In-Reply-To: <1330161068-8413-3-git-send-email-vthiagar@qca.qualcomm.com>
On 02/25/2012 11:11 AM, Vasanthakumar Thiagarajan wrote:
> Split the wmi event processing into the one which needs to be
> vif specific and the reset. This is a step towards avoiding
> the need for wiphy and a netdev registration before getting
> any message from firmware.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/wmi.c | 200 ++++++++++++++++-----------------
> 1 files changed, 99 insertions(+), 101 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c
> index bbbe0a7..0527933 100644
> --- a/drivers/net/wireless/ath/ath6kl/wmi.c
> +++ b/drivers/net/wireless/ath/ath6kl/wmi.c
> @@ -3369,32 +3369,101 @@ static int ath6kl_wmi_roam_tbl_event_rx(struct wmi *wmi, u8 *datap, int len)
> return ath6kl_debug_roam_tbl_event(wmi->parent_dev, datap, len);
> }
>
> -/* Control Path */
> -int ath6kl_wmi_control_rx(struct wmi *wmi, struct sk_buff *skb)
> +/* Process interface specific wmi events, caller would free the datap */
> +static int ath6kl_wmi_proc_events_iface(struct wmi *wmi, u16 if_idx, u16 cmd_id,
> + u8 *datap, u32 len)
> {
Please rename this to ath6kl_wmi_proc_events_vif() or something similar.
Better to use term vif everywhere, it's not clear that iface here means vif.
Otherwise the patchset looks good to me.
Kalle
next prev parent reply other threads:[~2012-02-28 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 9:11 [PATCH V2 1/5] ath6kl: Group wiphy initialization into ath6kl_cfg80211_init() Vasanthakumar Thiagarajan
2012-02-25 9:11 ` [PATCH V2 2/5] ath6kl: Initialize netdev hw_features for every interface Vasanthakumar Thiagarajan
2012-02-25 9:11 ` [PATCH V2 3/5] ath6kl: Refactor ath6kl_wmi_control_rx() Vasanthakumar Thiagarajan
2012-02-28 9:10 ` Kalle Valo [this message]
2012-02-25 9:11 ` [PATCH V2 4/5] ath6kl: Skip vif index validation in ath6kl_rx() for wmi events Vasanthakumar Thiagarajan
2012-02-25 9:11 ` [PATCH V2 5/5] ath6kl: Defer wiphy and netdev registration till the end of ath6kl_core_init() Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C9A03.2080906@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).