Re: [PATCH] cfg80211: Add background scan period attribute.

[bkamatch <bkamatch@qca.qualcomm.com>]

On 02/29/2012 06:09 PM, Johannes Berg wrote:
> On Wed, 2012-02-29 at 18:04 +0530, Bala Shanmugam wrote:
>> Receive background scan period as part of connect
>> command and pass the same to driver.
>>
>> Signed-off-by: Bala Shanmugam<bkamatch@qca.qualcomm.com>
>> ---
>>   include/linux/nl80211.h |    8 ++++++++
>>   include/net/cfg80211.h  |    2 ++
>>   net/wireless/nl80211.c  |    7 +++++++
>>   net/wireless/wext-sme.c |    5 +++++
>>   4 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
>> index ad56e21..7cef223 100644
>> --- a/include/linux/nl80211.h
>> +++ b/include/linux/nl80211.h
>> @@ -367,6 +367,9 @@
>>    *	%NL80211_ATTR_WIPHY_FREQ, %NL80211_ATTR_CONTROL_PORT,
>>    *	%NL80211_ATTR_CONTROL_PORT_ETHERTYPE and
>>    *	%NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT.
>> + *	Background scan period can also be
>> + *	optionally specified in %NL80211_ATTR_BG_SCAN_PERIOD.
>> + *	If period value is 0, bg scan will be disabled.
> Nack. We leave out the attribute in those cases and make 0 an invalid
> value.
This is an optional attribute and if we leave out,
BG scan is enabled with default period. We need to disable it
by passing some specific value through this attribute.
I choose 0 for it.
> Also please have this reviewed internally first. I'm tired of pointing
> out all the whitespace, code formatting, etc. issues from QCA folks.
Sorry for any mistakes.  This patch is internally reviewed and
cleared checkpatch.
> johannes
>