From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, mcgrof@qca.qualcomm.com,
rmanohar@qca.qualcomm.com
Subject: Re: [PATCH 3.3 1/4] Revert "ath9k_hw: Fix false tx hung detection in AR9003 chips"
Date: Wed, 29 Feb 2012 19:24:44 +0100 [thread overview]
Message-ID: <4F4E6D6C.5010605@openwrt.org> (raw)
In-Reply-To: <20120229180825.GB13733@tuxdriver.com>
On 2012-02-29 7:08 PM, John W. Linville wrote:
> On Mon, Feb 27, 2012 at 07:58:39PM +0100, Felix Fietkau wrote:
>> The approach of this change is flawed, as it triggers tx status processing
>> from more callsites, yet the chips only have one global tx status queue.
>> Subsequent patches will properly fix the issue that this one tried to address.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> How flawed is the current approach? That commit looks like it has been
> around for months already. Does it really _need_ to be fixed in 3.3?
It only slightly reduces the severity of the issue it tried to address,
while adding some ugly race conditions. It is not possible to properly
fix the issue without a revert of that commit, so I really would like to
see this patch series in 3.3.
- Felix
next prev parent reply other threads:[~2012-02-29 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 18:58 [PATCH 3.3 1/4] Revert "ath9k_hw: Fix false tx hung detection in AR9003 chips" Felix Fietkau
2012-02-27 18:58 ` [PATCH 3.3 2/4] ath9k: do not call ath9k_hw_txprocdesc on AR9003 outside of the tx tasklet Felix Fietkau
2012-02-27 18:58 ` [PATCH 3.3 3/4] ath9k_hw: enable interrupts for beacon tx completion events Felix Fietkau
2012-02-27 18:58 ` [PATCH 3.3 4/4] ath9k: fix drv_tx_last_beacon on AR9003 by processing beacon tx status Felix Fietkau
2012-02-29 18:08 ` [PATCH 3.3 1/4] Revert "ath9k_hw: Fix false tx hung detection in AR9003 chips" John W. Linville
2012-02-29 18:24 ` Felix Fietkau [this message]
2012-03-05 19:33 ` John W. Linville
2012-03-05 20:22 ` Manoharan, Rajkumar
2012-03-05 20:24 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E6D6C.5010605@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).