Re: [RFC 2/2] ath9k_htc: use ieee80211_free_txskb

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Christian,


On Monday 27 February 2012 10:02 PM, Christian Lamparter wrote:
> With the new tx status API: "mac80211: implement wifi TX status"
> All skb originating from mac80211 needs to be given back to mac80211.
>
> Signed-off-by: Christian Lamparter<chunkeey@googlemail.com>
> ---
> It compiles, but not tested.
> ---
>   drivers/net/wireless/ath/ath9k/htc_drv_txrx.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index 3e40a64..e958704 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -451,7 +451,7 @@ static void ath9k_htc_tx_process(struct ath9k_htc_priv *priv,
>
>   	slot = strip_drv_header(priv, skb);
>   	if (slot<  0) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>
> @@ -687,7 +687,7 @@ void ath9k_htc_txep(void *drv_priv, struct sk_buff *skb,
>
>   	epid_queue = get_htc_epid_queue(priv, ep_id);
>   	if (!epid_queue) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>

also we should do it ath9k_htc_tx in htc_drv_main.c, i don't know very 
much about ath9k_htc.


-- 
thanks,
shafi