Re: [PATCH] bcma: add support for on-chip OTP memory used for SPROM storage

["Arend van Spriel" <arend@broadcom.com>]

On 03/06/2012 02:34 PM, Arend van Spriel wrote:
> Wireless Broadcom chips can have either their SPROM data stored
> on either external SPROM or on-chip OTP memory. Both are accessed
> through the same register space. This patch adds support for the
> on-chip OTP memory.

John,

Please drop this patch. Better to split down this patch as it addresses 
two issues (although related).

> diff --git a/drivers/bcma/sprom.c b/drivers/bcma/sprom.c
> index 916ae25..cdcf75c 100644
> --- a/drivers/bcma/sprom.c
> +++ b/drivers/bcma/sprom.c
> @@ -49,10 +49,23 @@ int bcma_arch_register_fallback_sprom(int (*sprom_callback)(struct bcma_bus *bus
>   static int bcma_fill_sprom_with_fallback(struct bcma_bus *bus,
>   					 struct ssb_sprom *out)
>   {
> -	if (!get_fallback_sprom)
> -		return -ENOENT;
> +	int err;
>
> -	return get_fallback_sprom(bus, out);
> +	if (!get_fallback_sprom) {
> +		err = -ENOENT;
> +		goto fail;
> +	}
> +
> +	err = get_fallback_sprom(bus, out);
> +	if (err)
> +		goto fail;
> +
> +	pr_debug("Using SPROM revision %d provided by"
> +		 " platform.\n", bus->sprom.revision);
> +	return 0;
> +fail:
> +	pr_warn("Using fallback SPROM failed (err %d)\n", err);
> +	return err;
>   }

Commit message does not cover the above change.

Gr. AvS