From: Raja Mani <rmani@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH v2] ath6kl: Add provision to define suspend policy in disconnected state.
Date: Wed, 7 Mar 2012 10:50:35 +0530 [thread overview]
Message-ID: <4F56F023.1090201@qca.qualcomm.com> (raw)
In-Reply-To: <4F563776.8090000@qca.qualcomm.com>
On Tuesday 06 March 2012 09:42 PM, Kalle Valo wrote:
> On 03/06/2012 11:33 AM, rmani@qca.qualcomm.com wrote:
>> From: Raja Mani<rmani@qca.qualcomm.com>
>>
>> It gives flexibility to the user to define suspend policy
>> when the suspend mode is set to WOW and the device is in
>> disconnected state at the time of suspend.
>>
>> New module parameter wow_mode is added to get the choice
>> from the user. This parameter is valid only if the module
>> parameter suspend_mode is set to WOW.
>>
>> To force WOW in connected state and cut power
>> in disconnected state:
>> suspend_mode=0x3 wow_mode=0x1
>>
>> To force WOW in connected state and deep sleep
>> in disconnected state:
>> suspend_mode=0x3 wow_mode=0x2
>>
>> If there is no value specified to wow_mode during insmod,
>> deep sleep mode will be tried in the disconnected state.
>>
>> Signed-off-by: Raja Mani<rmani@qca.qualcomm.com>
>
> [...]
>
>> + if (ret&& (!ar->wow_suspend_mode ||
>> + ar->wow_suspend_mode == WLAN_POWER_STATE_DEEP_SLEEP))
>> + try_deepsleep = true;
>
> I don't get this part. If the wow_mode parameter is set to 0 or 2 the
> functionality is the same, right? So what's the point with 0x2 the
> commit log? Deep sleep will be the default in disconnected anyway.
> Unless I misunderstood something, of course.
Yes, the functionality is the same for both cases (0 or 2).
passing 2 to wow_mode is an explicitly option.
The value 0 is the default case.
Should we remove option 2 in wow_mode and keep only
option 1 ?
>
> Kalle
next prev parent reply other threads:[~2012-03-07 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 9:33 [PATCH v2] ath6kl: Add provision to define suspend policy in disconnected state rmani
2012-03-06 16:12 ` Kalle Valo
2012-03-07 5:20 ` Raja Mani [this message]
2012-03-07 6:46 ` Kalle Valo
2012-03-07 7:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F56F023.1090201@qca.qualcomm.com \
--to=rmani@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).