Re: [PATCH v2] cfg80211: Add background scan period attribute.

[bkamatch <bkamatch@qca.qualcomm.com>]

On 03/01/2012 07:53 PM, Johannes Berg wrote:
> On Thu, 2012-03-01 at 12:09 +0530, Bala Shanmugam wrote:
>> Receive background scan period as part of connect
>> command and pass the same to driver.
>>
>> Signed-off-by: Bala Shanmugam<bkamatch@qca.qualcomm.com>
>> ---
>>   include/linux/nl80211.h |    9 +++++++++
>>   include/net/cfg80211.h  |    3 +++
>>   net/wireless/nl80211.c  |    7 +++++++
>>   net/wireless/wext-sme.c |    3 +++
>>   4 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
>> index be35a68..e81d327 100644
>> --- a/include/linux/nl80211.h
>> +++ b/include/linux/nl80211.h
>> @@ -369,6 +369,10 @@
>>    *	%NL80211_ATTR_WIPHY_FREQ, %NL80211_ATTR_CONTROL_PORT,
>>    *	%NL80211_ATTR_CONTROL_PORT_ETHERTYPE and
>>    *	%NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT.
>> + *	Background scan period can optionally be
>> + *	specified in %NL80211_ATTR_BG_SCAN_PERIOD,
>> + *	if not specified default background scan configuration
>> + *	in driver is used and if period value is 0, bg scan will be disabled.
> Maybe this should also indicate that the value is ignored unless the
> device advertises roaming support with NL80211_ATTR_ROAM_SUPPORT?
>
> I'm not sure I like the whole default value thing since it's kinda
> magic, but I guess I can live with it.
>
> johannes
>

Thats true.  Thanks for pointing it.

Regards,
Bala.